Skip to content

Canonical AA v0.7 Support#780

Merged
derekpierre merged 5 commits into
nucypher:epic-v0.7.xfrom
derekpierre:canonical-v07
Apr 21, 2026
Merged

Canonical AA v0.7 Support#780
derekpierre merged 5 commits into
nucypher:epic-v0.7.xfrom
derekpierre:canonical-v07

Conversation

@derekpierre
Copy link
Copy Markdown
Member

@derekpierre derekpierre commented Apr 21, 2026

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
Reopened from #776 and targeted for epic-v0.7.x.

from CoPilot:

  • Bump @nucypher/nucypher-core from 0.15.1-dev.3 to 0.15.1-dev.4 across root/workspace dependencies and lockfile.
  • Extend TACo signing tests to cover AA version 0.7.0 (for both UserOp and PackedUserOp).
  • Update signUserOp TypeScript signature to accept aaVersion: 'mdt' | '0.7.0' | '0.8.0'.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TACo web monorepo to support canonical Account Abstraction (AA) v0.7 signing by bumping the @nucypher/nucypher-core dependency and extending signing tests/API typing to include 0.7.0.

Changes:

  • Bump @nucypher/nucypher-core from 0.15.1-dev.3 to 0.15.1-dev.4 across root/workspace dependencies and lockfile.
  • Extend TACo signing tests to cover AA version 0.7.0 (for both UserOp and PackedUserOp).
  • Update signUserOp TypeScript signature to accept aaVersion: 'mdt' | '0.7.0' | '0.8.0'.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-lock.yaml Resolves workspace dependencies to @nucypher/nucypher-core@0.15.1-dev.4 and updates importer entries accordingly.
package.json Bumps root dependency + pnpm override for @nucypher/nucypher-core to dev.4.
packages/shared/package.json Bumps @nucypher/nucypher-core dependency to dev.4 for shared package.
packages/taco/package.json Bumps @nucypher/nucypher-core dependency to dev.4 for taco package.
packages/taco/src/sign.ts Adds 0.7.0 to the supported aaVersion type union for signUserOp.
packages/taco/test/taco-sign.test.ts Adds test matrix entries for 0.7.0 and adjusts typing/assertions around AA version.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/taco/src/sign.ts
Comment thread packages/taco/test/taco-sign.test.ts Outdated
Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (55d7dc7) to head (da4737f).
⚠️ Report is 325 commits behind head on epic-v0.7.x.

Additional details and impacted files
@@               Coverage Diff               @@
##           epic-v0.7.x     #780      +/-   ##
===============================================
+ Coverage        87.45%   90.29%   +2.84%     
===============================================
  Files               82       98      +16     
  Lines             5778     8678    +2900     
  Branches           391      567     +176     
===============================================
+ Hits              5053     7836    +2783     
- Misses             688      799     +111     
- Partials            37       43       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@derekpierre derekpierre changed the title Canonical v07 Canonical AA v0.7 Support Apr 21, 2026
@derekpierre derekpierre merged commit 760969f into nucypher:epic-v0.7.x Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants