Canonical AA v0.7 Support#780
Conversation
746ba48 to
7a4e1c7
Compare
There was a problem hiding this comment.
Pull request overview
Updates the TACo web monorepo to support canonical Account Abstraction (AA) v0.7 signing by bumping the @nucypher/nucypher-core dependency and extending signing tests/API typing to include 0.7.0.
Changes:
- Bump
@nucypher/nucypher-corefrom0.15.1-dev.3to0.15.1-dev.4across root/workspace dependencies and lockfile. - Extend TACo signing tests to cover AA version
0.7.0(for both UserOp and PackedUserOp). - Update
signUserOpTypeScript signature to acceptaaVersion: 'mdt' | '0.7.0' | '0.8.0'.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Resolves workspace dependencies to @nucypher/nucypher-core@0.15.1-dev.4 and updates importer entries accordingly. |
| package.json | Bumps root dependency + pnpm override for @nucypher/nucypher-core to dev.4. |
| packages/shared/package.json | Bumps @nucypher/nucypher-core dependency to dev.4 for shared package. |
| packages/taco/package.json | Bumps @nucypher/nucypher-core dependency to dev.4 for taco package. |
| packages/taco/src/sign.ts | Adds 0.7.0 to the supported aaVersion type union for signUserOp. |
| packages/taco/test/taco-sign.test.ts | Adds test matrix entries for 0.7.0 and adjusts typing/assertions around AA version. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## epic-v0.7.x #780 +/- ##
===============================================
+ Coverage 87.45% 90.29% +2.84%
===============================================
Files 82 98 +16
Lines 5778 8678 +2900
Branches 391 567 +176
===============================================
+ Hits 5053 7836 +2783
- Misses 688 799 +111
- Partials 37 43 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ludes AA v0.7 support.
… parameter Update test.
Update test to use new type.
1c3ca7d to
da4737f
Compare
Type of PR:
Required reviews:
What this does:
Reopened from #776 and targeted for
epic-v0.7.x.from CoPilot:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: