Skip to content

Comments

Use structured containers instead of protobuf#538

Draft
cthulhu-rider wants to merge 3 commits intomasterfrom
container-use-structs
Draft

Use structured containers instead of protobuf#538
cthulhu-rider wants to merge 3 commits intomasterfrom
container-use-structs

Conversation

@cthulhu-rider
Copy link
Contributor

continues #534

This declares struct for containers similar to
71fc8a9. Now containers are stored and
available for reading in two formats - structured and protobuf. The
former is available via new `getInfo` call. The latter is retained
for safety. It will be removed in the future.

New creation method `createV2` accepts structured container and replaces
all other methods.

Structured items for already existing items are calculated on update.

Refs #449.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Same as fc41e7a.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Just delete them upon request. These items will be removed from storage
in the future.

Refs #449.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider added the blocked Can't be done because of something label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 71.51163% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.66%. Comparing base (6bd4213) to head (1bd6923).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
contracts/container/contract.go 74.55% 71 Missing ⚠️
internal/proto/message.go 33.33% 16 Missing ⚠️
internal/proto/encoding.go 72.22% 10 Missing ⚠️
internal/proto/util.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   63.88%   64.66%   +0.77%     
==========================================
  Files          24       27       +3     
  Lines        2653     2977     +324     
==========================================
+ Hits         1695     1925     +230     
- Misses        952     1046      +94     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Can't be done because of something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant