Skip to content

Drop container protobuf#539

Draft
cthulhu-rider wants to merge 4 commits intomasterfrom
drop-container-protobuf
Draft

Drop container protobuf#539
cthulhu-rider wants to merge 4 commits intomasterfrom
drop-container-protobuf

Conversation

@cthulhu-rider
Copy link
Copy Markdown
Contributor

@cthulhu-rider cthulhu-rider commented Nov 14, 2025

continues #538

@cthulhu-rider
container: Store containers as structures
5fad1b6 
This declares struct for containers similar to
71fc8a9. Now containers are stored and
available for reading in two formats - structured and protobuf. The
former is available via new `getInfo` call. The latter is retained
for safety. It will be removed in the future.

New creation method `createV2` accepts structured container and replaces
all other methods.

Structured items for already existing items are calculated on update.

Refs #449.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
testdata: Refresh test dumps
51632b5 
Same as fc41e7a.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
container: Do not create or read container protobuf storage items
1bd6923 
Just delete them upon request. These items will be removed from storage
in the future.

Refs #449.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
container: Drop container protobuf items from storage
3ad80a0 
They are not read since 1bd6923.

Closes #449.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider added the blocked Can't be done because of something label Nov 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 70.89337% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.58%. Comparing base (6bd4213) to head (3ad80a0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
contracts/container/contract.go 73.75% 74 Missing ⚠️
internal/proto/message.go 33.33% 16 Missing ⚠️
internal/proto/encoding.go 72.22% 10 Missing ⚠️
internal/proto/util.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   63.88%   64.58%   +0.69%     
==========================================
  Files          24       27       +3     
  Lines        2653     2979     +326     
==========================================
+ Hits         1695     1924     +229     
- Misses        952     1049      +97     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider mentioned this pull request Nov 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carpawell carpawell Awaiting requested review from carpawell carpawell will be requested when the pull request is marked ready for review carpawell is a code owner

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov will be requested when the pull request is marked ready for review roman-khimov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

blocked Can't be done because of something

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cthulhu-rider