Skip to content

feat/add log streaming u9 oee #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianburrous-nominal wants to merge 2 commits into
base: main
Choose a base branch
from
+401 −1
Open

feat/add log streaming u9 oee #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd84d64
feat: add NominalLogStream for streaming logs to Nominal datasets
claude Mar 12, 2026
a874528
refactor: use conjure-generated types for log streaming
claude Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion nominal-streaming/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use conjure_runtime_rustls_platform_verifier::ResponseBody;
use nominal_api::api::rids::NominalDataSourceOrDatasetRid;
use nominal_api::api::rids::WorkspaceRid;
use nominal_api::ingest::api::IngestServiceAsyncClient;
use nominal_api::storage::writer::api::NominalChannelWriterServiceAsyncClient;
use nominal_api::upload::api::UploadServiceAsyncClient;
use snap::write::FrameEncoder;
use url::Url;
Expand Down Expand Up @@ -67,6 +68,7 @@ pub struct NominalApiClients {
pub streaming: PlatformVerifierClient,
pub upload: UploadServiceAsyncClient<PlatformVerifierClient>,
pub ingest: IngestServiceAsyncClient<PlatformVerifierClient>,
pub channel_writer: NominalChannelWriterServiceAsyncClient<PlatformVerifierClient>,
}

impl Debug for NominalApiClients {
Expand All @@ -75,6 +77,7 @@ impl Debug for NominalApiClients {
.field("streaming", &"Client")
.field("upload", &"UploadServiceAsyncClient<Client>")
.field("ingest", &"IngestServiceAsyncClient<Client>")
.field("channel_writer", &"NominalChannelWriterServiceAsyncClient<Client>")
.finish()
}
}
Expand All @@ -97,7 +100,8 @@ impl NominalApiClients {
Self {
streaming,
upload: UploadServiceAsyncClient::new(services.clone()),
ingest: IngestServiceAsyncClient::new(services),
ingest: IngestServiceAsyncClient::new(services.clone()),
channel_writer: NominalChannelWriterServiceAsyncClient::new(services),
}
}

Expand Down
5 changes: 5 additions & 0 deletions nominal-streaming/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ let stream = NominalDatasetStreamBuilder::new()
pub mod client;
pub mod consumer;
pub mod listener;
pub mod log_stream;
pub mod stream;
pub mod types;
pub mod upload;
Expand All @@ -184,6 +185,10 @@ pub mod prelude {
pub use nominal_api::tonic::io::nominal::scout::api::proto::WriteRequestNominal;

pub use crate::consumer::NominalCoreConsumer;
pub use crate::log_stream::LogPoint;
pub use crate::log_stream::NominalLogStream;
pub use crate::log_stream::NominalLogStreamBuilder;
pub use crate::log_stream::NominalLogStreamOpts;
pub use crate::stream::NominalDatasetStream;
#[expect(deprecated)]
pub use crate::stream::NominalDatasourceStream;
Expand Down
Loading
Loading