Open
Conversation
Mirrors the nominal-client log streaming approach (process_log_batch /
Dataset.get_log_stream): buffers LogPoints and flushes them as a
conjure WriteLogsRequest JSON payload to
POST /storage/writer/v1/logs/{dataSourceRid}.
Key additions:
- `log_stream` module: NominalLogStream, NominalLogStreamBuilder,
NominalLogStreamOpts, LogPoint
- `client::encode_log_request`: builds the conjure HTTP request for the
writeLogs endpoint (application/json, no snappy compression)
- serde with derive feature added to support JSON serialisation of the
wire types (TimestampJson { seconds, nanos } matching global.Timestamp)
https://claude.ai/code/session_01JVWvvQy41MRcqirj9WJj5P
Replace hand-crafted JSON serialization structs with the conjure-generated `NominalChannelWriterServiceAsyncClient`, `WriteLogsRequest`, `ApiLogPoint`, `LogValue`, `Timestamp`, and `Channel` types from `nominal_api::storage::writer::api`. - Add `channel_writer: NominalChannelWriterServiceAsyncClient` to `NominalApiClients` initialized from the `services` conjure client handle - Remove `encode_log_request()` in favour of calling `channel_writer.write_logs()` directly in `NominalLogStream::flush()` - Remove `serde` derive dependency (was only needed for the now-deleted JSON structs) https://claude.ai/code/session_01JVWvvQy41MRcqirj9WJj5P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.