Skip to content

fix(ci): publishing workflow improvements #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 6 commits into from
Mar 6, 2026
+2 −2
Merged

fix(ci): publishing workflow improvements #648

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6409d53
Remove pnpm option from publish workflow
avivkeller Mar 5, 2026
13c1515
fixup!
avivkeller Mar 5, 2026
3f75799
fixup!
avivkeller Mar 5, 2026
46768b4
fixup!
avivkeller Mar 5, 2026
d0bb74f
fixup!
avivkeller Mar 5, 2026
a66cc26
fixup!
avivkeller Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- name: Verify commit authenticity
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event_name != 'workflow_dispatch' }}
run: |
# Get commit data from GitHub API to verify its authenticity
COMMIT_DATA=$(gh api repos/${{ github.repository }}/commits/$COMMIT_SHA)
Expand Down Expand Up @@ -66,7 +67,7 @@ jobs:
run: |
OLD_VERSION=$(git show $COMMIT_SHA~1:package.json | jq -r '.version')
NEW_VERSION=$(jq -r '.version' "package.json")
if [ "$OLD_VERSION" != "$NEW_VERSION" ]; then
if [ "$OLD_VERSION" != "$NEW_VERSION" ] || [ "$EVENT_NAME" == "workflow_dispatch" ]; then
echo "should_publish=true" >> $GITHUB_OUTPUT
fi

Expand All @@ -77,7 +78,6 @@ jobs:
steps:
- uses: nodejs/web-team/actions/setup-environment@9f3c83af227d721768d9dbb63009a47ed4f4282f
with:
pnpm: true
use-version-file: true
registry-url: 'https://registry.npmjs.org'

Expand Down
Loading