Repository navigation
Add native pointer clicks, drawing export, and freeform screenshots - #5
Closed
charlesanim wants to merge 1 commit into
Closed
charlesanim wants to merge 1 commit into
charlesanim wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 177a4e89-321a-4dda-aa20-96bb2d75b334
This was referenced Nov 2, 2026
Owner
|
Thank you for the PR but there are no plans to extend it beyond what it does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Both exports use a native Save dialog. Cancel preserves the drawing/selection. Screenshot permission is requested only when capturing, with actionable errors if access is denied. The toolbar, menu, onboarding text, and documentation describe the new modes.
Upstream deliberately consumed normal clicks; separating Pointer and Draw makes real interaction the default without losing presentation-only drawing. Option still temporarily passes input through while drawing or selecting.
Evidence
The attached recording is a live macOS run over a separate, privacy-safe fixture, not a mockup. The attached PNGs include the native toolbar and actual files written by the Save dialogs. The fixture deliberately covers other desktop content, including the Save dialogs, while recording.
Reproduce the capture flow with
python3 scripts/capture-evidence.py dist/evidence(Accessibility and Screen Recording required). The script also checks mode controls, native event delivery, drawing isolation, real file saves, cancellation, and transparency.Image export and routing regressions run in
swift test; the universal Apple Silicon/Intel release builds locally. macOS 14+ uses ScreenCaptureKit. The macOS 13 system-tool fallback compiles but has not been exercised on macOS 13 hardware.Supersedes the fork-only PR: charlesanim#1.
demo.mp4
Linked issues
Closes #4 (native clicking and dragging).
Closes #7 (drawing PNG export).
Closes #6 (freeform screenshot capture).