raise TypeError if input is not list of str for convert_list_to_comma_separated_string converter#2154
Merged
ni-jfitzger merged 2 commits intoni:masterfrom Jan 8, 2026
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2154 +/- ##
=======================================
Coverage 90.07% 90.08%
=======================================
Files 71 71
Lines 18664 18666 +2
=======================================
+ Hits 16812 16815 +3
+ Misses 1852 1851 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
reviewed
Jan 7, 2026
ni-jfitzger
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
convert_list_to_comma_separated_string converter now checks if the input is a list of str and raise a TypeError if its not, so that we do not accidentally take in any other type of input and do a join on that in case of writeable attributes using this type.
List issues fixed by this Pull Request below, if any.
convert_list_to_comma_separated_string was assuming a list input, which could be wrong.
What testing has been done?
Add a nifake unit test to confirm that TypeError is thrown.