Updated few nirfsg properties to have string and interval datatypes consistent with other APIs in repository#2152
Merged
ni-jfitzger merged 4 commits intoni:masterfrom Jan 7, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2152 +/- ##
=======================================
Coverage 90.07% 90.08%
=======================================
Files 71 71
Lines 18664 18664
=======================================
+ Hits 16812 16813 +1
+ Misses 1852 1851 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
reviewed
Jan 5, 2026
ni-jfitzger
reviewed
Jan 5, 2026
marcoskirsch
previously requested changes
Jan 5, 2026
…o usenewattribclasses
ni-jfitzger
approved these changes
Jan 7, 2026
Requested changes were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
external_calibration_recommended_intervalproperty to return a hightime.timedelta object instead of months as an int, aligning with other APIs in the repositoryavailable_pathsavailable_portsfixed_group_delay_across_portsgroup_capabilitiessupported_instrument_modelsList issues fixed by this Pull Request below, if any.
None
What testing has been done?
System tests executed successfully with changes to attributes.