-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update third_party/ni-apis digest to de7e7d3 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Resultsββ120 filesβ Β±0ββββ120 suitesβ Β±0βββ3m 22s β±οΈ -4s Results for commit ad97017.βΒ± Comparison against base commit e863e4d. β»οΈ This comment has been updated with latest results. |
|
@jfriedri-ni @bkeryan In this case, we don't need to wait 14 days for ni-apis changes I think. So I'm intending to override the renovate check and squash this. Do you guys agree? Is there a renovate change or exception we need to make to allow not waiting in this scenario? |
We could likely scope the age-rule to package manager categories -- keep Python on the timer but allow git submodules to update at any age. |
Not super familiar with renovate, but would that just be adding a 'minimumReleaseAge' to this rule that's already in place? |
|
@jfriedri-ni @bkeryan Copilot says I can do this. I think 2 days seems like a good time. Lmk if you want something different. {
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"local>ni/python-renovate-config:recommended",
"local>ni/python-renovate-config//presets/enableGitSubmodules"
],
"packageRules": [
{
"description": "Update ni-apis on early Monday mornings.",
"matchDepNames": [
"third_party/ni-apis"
],
"extends": [
"schedule:weekly"
],
"minReleaseAge": "2d"
}
]
} |
8d0ac29 to
2394619
Compare
d789d01 to
030fe30
Compare
|
Well, whatever I did in #292 didn't seem to work. I did check the 'Rebase' box in the PR description and it re-ran the checks. Is there more to do? I also tried to look at the renovate log you get when you click 'Details' on the check, but I couldn't tell from that what might be wrong. Oh, nevermind. I guess it also updated to this recent commit 6 hours ago in the process. So I'll check again tomorrow around noon. |
You should be able to merge this without waiting. renovate/stability-days is not in the ruleset's required checks. |
Good point. I'm still going to wait to see if it goes green to test my changes are working. |
6824856 to
0bebe8f
Compare
@bkeryan I'm wondering if this 'weekly' schedule prevents renovate from even checking the stability days except for once a week. So far I haven't gotten it to update the check on this PR in spite of several rebase and dependency dashboard check box attempts. I'm thinking I'll try changing this schedule to, e.g. hourly even if temporary to see if I can get the step to go green. My suspicion is that if we don't change anything, it might go green next Monday. |
0bebe8f to
ad97017
Compare
This PR contains the following updates:
6c8178dβde7e7d3Configuration
π Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone US/Central, Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.