Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 12, 2026

This PR contains the following updates:

Package Update Change
third_party/ni-apis digest 6c8178d β†’ de7e7d3

Configuration

πŸ“… Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone US/Central, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Test Results

β€‡β€ˆ120 files  Β±0β€‚β€ƒβ€‡β€ˆ120 suites  Β±0   3m 22s ⏱️ -4s
β€‡β€ˆ249 tests Β±0β€‚β€ƒβ€‡β€ˆ247 βœ… Β±0   2 πŸ’€ Β±0  0 ❌ Β±0 
2β€ˆ490 runsβ€Š Β±0  2β€ˆ460 βœ… Β±0  30 πŸ’€ Β±0  0 ❌ Β±0 

Results for commit ad97017. ± Comparison against base commit e863e4d.

♻️ This comment has been updated with latest results.

@dixonjoel
Copy link
Collaborator

@jfriedri-ni @bkeryan In this case, we don't need to wait 14 days for ni-apis changes I think. So I'm intending to override the renovate check and squash this. Do you guys agree? Is there a renovate change or exception we need to make to allow not waiting in this scenario?

@jfriedri-ni
Copy link
Collaborator

Is there a renovate change or exception we need to make to allow not waiting in this scenario?

We could likely scope the age-rule to package manager categories -- keep Python on the timer but allow git submodules to update at any age.

@dixonjoel
Copy link
Collaborator

Is there a renovate change or exception we need to make to allow not waiting in this scenario?

We could likely scope the age-rule to package manager categories -- keep Python on the timer but allow git submodules to update at any age.

Not super familiar with renovate, but would that just be adding a 'minimumReleaseAge' to this rule that's already in place?
"packageRules": [
{
"description": "Update ni-apis on early Monday mornings.",
"matchDepNames": [
"third_party/ni-apis"
],
"extends": [
"schedule:weekly"
]
}
]
I'll take a look at this more closely.

@dixonjoel
Copy link
Collaborator

@jfriedri-ni @bkeryan Copilot says I can do this. I think 2 days seems like a good time. Lmk if you want something different.

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": [
        "local>ni/python-renovate-config:recommended",
        "local>ni/python-renovate-config//presets/enableGitSubmodules"
    ],
    "packageRules": [
        {
            "description": "Update ni-apis on early Monday mornings.",
            "matchDepNames": [
                "third_party/ni-apis"
            ],
            "extends": [
                "schedule:weekly"
            ],
            "minReleaseAge": "2d"
        }
    ]
}

@renovate renovate bot force-pushed the users/renovate/third_party-ni-apis-digest branch from 8d0ac29 to 2394619 Compare January 12, 2026 16:11
@renovate renovate bot changed the title chore(deps): update third_party/ni-apis digest to fab96f3 chore(deps): update third_party/ni-apis digest to de7e7d3 Jan 12, 2026
@renovate renovate bot force-pushed the users/renovate/third_party-ni-apis-digest branch 2 times, most recently from d789d01 to 030fe30 Compare January 12, 2026 22:02
@dixonjoel
Copy link
Collaborator

dixonjoel commented Jan 12, 2026

Well, whatever I did in #292 didn't seem to work. I did check the 'Rebase' box in the PR description and it re-ran the checks. Is there more to do? I also tried to look at the renovate log you get when you click 'Details' on the check, but I couldn't tell from that what might be wrong.

@bkeryan @jfriedri-ni

Oh, nevermind. I guess it also updated to this recent commit 6 hours ago in the process. So I'll check again tomorrow around noon.

ni/ni-apis@de7e7d3

@bkeryan
Copy link
Collaborator

bkeryan commented Jan 13, 2026

Well, whatever I did in #292 didn't seem to work. I did check the 'Rebase' box in the PR description and it re-ran the checks. Is there more to do? I also tried to look at the renovate log you get when you click 'Details' on the check, but I couldn't tell from that what might be wrong.

@bkeryan @jfriedri-ni

Oh, nevermind. I guess it also updated to this recent commit 6 hours ago in the process. So I'll check again tomorrow around noon.

ni/ni-apis@de7e7d3

You should be able to merge this without waiting. renovate/stability-days is not in the ruleset's required checks.

@dixonjoel
Copy link
Collaborator

Well, whatever I did in #292 didn't seem to work. I did check the 'Rebase' box in the PR description and it re-ran the checks. Is there more to do? I also tried to look at the renovate log you get when you click 'Details' on the check, but I couldn't tell from that what might be wrong.
@bkeryan @jfriedri-ni
Oh, nevermind. I guess it also updated to this recent commit 6 hours ago in the process. So I'll check again tomorrow around noon.
ni/ni-apis@de7e7d3

You should be able to merge this without waiting. renovate/stability-days is not in the ruleset's required checks.

Good point. I'm still going to wait to see if it goes green to test my changes are working.

@renovate renovate bot force-pushed the users/renovate/third_party-ni-apis-digest branch 3 times, most recently from 6824856 to 0bebe8f Compare January 14, 2026 15:38
@dixonjoel
Copy link
Collaborator

Well, whatever I did in #292 didn't seem to work. I did check the 'Rebase' box in the PR description and it re-ran the checks. Is there more to do? I also tried to look at the renovate log you get when you click 'Details' on the check, but I couldn't tell from that what might be wrong.
@bkeryan @jfriedri-ni
Oh, nevermind. I guess it also updated to this recent commit 6 hours ago in the process. So I'll check again tomorrow around noon.
ni/ni-apis@de7e7d3

You should be able to merge this without waiting. renovate/stability-days is not in the ruleset's required checks.

Good point. I'm still going to wait to see if it goes green to test my changes are working.

@bkeryan I'm wondering if this 'weekly' schedule prevents renovate from even checking the stability days except for once a week. So far I haven't gotten it to update the check on this PR in spite of several rebase and dependency dashboard check box attempts. I'm thinking I'll try changing this schedule to, e.g. hourly even if temporary to see if I can get the step to go green. My suspicion is that if we don't change anything, it might go green next Monday.
"packageRules": [
{
"description": "Update ni-apis on early Monday mornings.",
"matchDepNames": [
"third_party/ni-apis"
],
"extends": [
"schedule:weekly"
],
"minimumReleaseAge": "1 day"
}
]

@renovate renovate bot force-pushed the users/renovate/third_party-ni-apis-digest branch from 0bebe8f to ad97017 Compare January 14, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants