Check ni-apis stability days daily

[dixonjoel]

What does this Pull Request accomplish?

Allows renovate to check needed updates to ni-apis every day instead of every week.

Why should this Pull Request be merged?

This is a bit of a speculation / test. I think that the weekly schedule may not even allow renovate to check stability days except for once a week. So if it checks on Monday and the stability days are not met, and then they are met on Tuesday, it won't 'go green' until next Monday when it checks again.

What testing has been done?

None. PR after submission, I'll wait one more day to see if this check goes green on #291

[github-actions]

Test Results

  120 files  ±0    120 suites  ±0   3m 29s ⏱️ +4s
  249 tests ±0    247 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 460 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 01665d4. ± Comparison against base commit 3d84663.

[dixonjoel]

@bkeryan @jfriedri-ni If my understanding is correct, it doesn't usually make sense to have the schedule run less often then the minimumReleaseAge.

[bkeryan]

This sets the update schedule for ni-apis to "daily", which affects more than the stability-days check.

[bkeryan]

@bkeryan @jfriedri-ni If my understanding is correct, it doesn't usually make sense to have the schedule run less often then the minimumReleaseAge.

They added new "key concepts" documentation for minimumReleaseAge in November that explains it better than the "configuration options" documentation:

https://docs.renovatebot.com/key-concepts/minimum-release-age/

It sounds like:

• minimumReleaseAge only works when the data source has a release timestamp.
• Older versions of Renovate used to ignore minimumReleaseAge when the data source doesn't have a release timestamp, but newer versions treat it as if the minimumReleaseAge has not been met. I guess this means it waits forever.
• The git-submodules manager uses the git-refs data source, which does not have release timestamps.

I guess we should disable minimumReleaseAge for git-submodules. (Alternative: set minimumReleaseAgeBehaviour=timestamp-optional, but I think this might hide issues.)

[bkeryan]

@bkeryan @jfriedri-ni If my understanding is correct, it doesn't usually make sense to have the schedule run less often then the minimumReleaseAge.

BTW I disagree with this. If Renovate defers creating the PR until the minimumReleaseAge is met, then it's fine to have weekly updates that only create a PR when the dependency is >=2 weeks old. The problem is when Renovate creates the PR before the stability-days check passes, and then it never passes.