Skip to content

4250 meta key linting #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DLBPointon wants to merge 2 commits into
base: dev
Choose a base branch
from
+2 −1
Open

4250 meta key linting #4280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c504b4f
Update regex to make it more specific for looking at meta variables i…
DLBPointon May 11, 2026
6688133
Add changes to changelog
DLBPointon May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Linting

- accept `process_low_memory` as a standard module label ([#4264](https://github.com/nf-core/tools/pull/4264))
- make regex for meta keys more specific to avoid false positives ([#XXXX](https://github.com/nf-core/tools/pull/XXXX))

### Modules

Expand Down
2 changes: 1 addition & 1 deletion nf_core/modules/lint/main_nf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def check_script_section(self, lines):
permitted_meta_keys = {"id", "single_end"}
invalid_meta_keys = [
f"{prefix}{key}"
for prefix, key in re.findall(r"\b(meta\d*\??\.)(\w+)\b(?!\()", script)
for prefix, key in re.findall(r"\b({(meta\d*\??\.)(\w+)\b(?!\()})", script)
if key not in permitted_meta_keys
]
if not invalid_meta_keys:
Expand Down
Loading