Skip to content

4250 meta key linting#4280

Open
DLBPointon wants to merge 2 commits into
devfrom
4250-meta_key_linting
Open

4250 meta key linting#4280
DLBPointon wants to merge 2 commits into
devfrom
4250-meta_key_linting

Conversation

@DLBPointon
Copy link
Copy Markdown

@DLBPointon DLBPointon commented May 11, 2026

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Fix, hopefully, makes the regex found in L307 of /nf_core/modules/lint/main_nf.py more specific so it is only looking for {meta.<something>} variables rather than "meta" the string in script.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.30%. Comparing base (b6af91a) to head (6688133).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DLBPointon
Copy link
Copy Markdown
Author

Ah ok, the main intention was to catch the def block in the script block.

I was focusing on inside the """ string block """

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant