Skip to content

Update output paths in bases2fastq module#9436

Closed
lucacozzuto wants to merge 1 commit intomasterfrom
lucacozzuto-patch-3
Closed

Update output paths in bases2fastq module#9436
lucacozzuto wants to merge 1 commit intomasterfrom
lucacozzuto-patch-3

Conversation

@lucacozzuto
Copy link
Copy Markdown
Contributor

Removing the hardcoded output name and pointing to prefix instead

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • [] If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Removing the hardcoded output name and pointing to prefix instead
@SPPearce SPPearce mentioned this pull request Feb 12, 2026
@SPPearce
Copy link
Copy Markdown
Contributor

Closing in favour of #9985

@SPPearce SPPearce closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants