Skip to content

Amulety modules bump versions#11645

Open
ggabernet wants to merge 24 commits into
nf-core:masterfrom
ggabernet:amulety
Open

Amulety modules bump versions#11645
ggabernet wants to merge 24 commits into
nf-core:masterfrom
ggabernet:amulety

Conversation

@ggabernet
Copy link
Copy Markdown
Member

  • update amulety version
  • update snapshot

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

- conda-forge::curl=8.20.0
- conda-forge::python=3.12.13
- conda-forge::wget=1.25.0
- pip:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also pin the version of pip from conda-forge

- pip:
- amulety==2.1.2
- torch==2.10.0
- amulety==2.1.3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These other tool versions should also be emitted

@ggabernet
Copy link
Copy Markdown
Member Author

@mashehu thanks for the review, I'll address your points!

I also saw that the tests failed due to no space left in the runner, even though the new container seemed to be smaller than the previous one so that's a bit puzzling. Can something be done like increasing the runners size for this specific module test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants