Fix krakenuniq build input deletion and tests#11607
Conversation
|
|
||
| """ | ||
| ${custom_db} | ||
| mkdir ${prefix} && cp -rL library taxonomy ${custom_seqid2taxid} ${prefix} |
There was a problem hiding this comment.
Removed the custom_db as it seems to be required. The nf-test doesn't describe an alternate way of using this module.
The updated meta.yml from #11587 also removes "Optional".
There was a problem hiding this comment.
This is the one bit I'm unsure about this PR - if you are copying the entireity of the library directory, which includes 100,000s of genomes, you will massively explode the harddrive usage of the process (e.g. 200 GB of input FASTAs to 400 GB by having two times the same set of FASTA files)
This is something I was trying to avoid with the original mv operation...
There was a problem hiding this comment.
I've removed the dereference -L. cp -r will just copy the symlinks as is, and then the rm cleans those ups. The test with keep_intermediate = true shows the files as being correctly removed. The original symlinks remain and the input files remain intact. The copied symlinks are removed.
|
Now why would the hash change for Edit: This is worrying. |
Description
keep_intermediatewas false.PR checklist
Closes #11557
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda