Skip to content

feat: civicpy/annotate module#11079

Open
emmcauley wants to merge 1 commit intonf-core:masterfrom
fulcrumgenomics:em_civipy_annotate
Open

feat: civicpy/annotate module#11079
emmcauley wants to merge 1 commit intonf-core:masterfrom
fulcrumgenomics:em_civipy_annotate

Conversation

@emmcauley
Copy link
Copy Markdown
Contributor

@emmcauley emmcauley commented Mar 27, 2026

PR checklist

Closes #11076.

This module adds CIVICpy, an analysis toolkit and SDK for extracting and analyzing knowledge from the CIViC knowledgebase. Tests are added.

⚠️ There seems to be something wrong with the pip and conda civicpy packages, they are both lacking backports:

Traceback (most recent call last):
  File "/usr/local/bin/civicpy", line 6, in <module>
    from civicpy.cli import cli
  File "/usr/local/lib/python3.12/site-packages/civicpy/cli.py", line 4, in <module>
    from civicpy import LOCAL_CACHE_PATH, civic
  File "/usr/local/lib/python3.12/site-packages/civicpy/civic.py", line 13, in <module>
    from backports.datetime_fromisoformat import MonkeyPatch
ModuleNotFoundError: No module named 'backports.datetime_fromisoformat'

Trying to add backports into the wave container build fails even if they're both from pip.

Also logged an issue on the civicpy repo here.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@emmcauley emmcauley marked this pull request as ready for review March 27, 2026 18:46
@emmcauley emmcauley force-pushed the em_civipy_annotate branch 2 times, most recently from 932b1eb to ef3d2d1 Compare March 27, 2026 19:12
@emmcauley emmcauley force-pushed the em_civipy_annotate branch from ef3d2d1 to 249aa89 Compare March 27, 2026 22:26
Comment on lines +7 to +8
? 'https://depot.galaxyproject.org/singularity/civicpy:5.2.0--pyhdfd78af_0'
: 'docker.io/griffithlab/civicpy:v5.2.0' }"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are non-standard because I ran into issues building the wave container for docker + singularity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: civicpy/anotate

1 participant