Update merqury build number (addresses a bug)#11070
Open
CormacKinsella wants to merge 2 commits intonf-core:masterfrom
Open
Update merqury build number (addresses a bug)#11070CormacKinsella wants to merge 2 commits intonf-core:masterfrom
CormacKinsella wants to merge 2 commits intonf-core:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Updated the merqury build number for the conda env, + both the docker & singularity biocontainers. The reason is the underlying meryl dependency was out of date (version 1.3), and led to empty qv files. Meryl has been updated to v1.4.1 in the latest build of merqury 1.3, see: update merqury: bump meryl dependency to 1.4.1 bioconda/bioconda-recipes#61223
Added version reporting for the meryl dependency
Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
nf-core modules test <MODULE> --profile singularity: