Conversation
Member
pinin4fjords
left a comment
pinin4fjords
left a comment
There was a problem hiding this comment.
Minor bits and pieces, but the general approach looks reasonable to me. Exomiser seems to require those versions, so they shouldn't go in ext.args, and it makes sense to put them in the tuples as you've done.
Comment on lines
+8
to
+10
| tuple val(meta), path(vcf), path(ped), val(assembly), path(phenopacket), path(analysis_script) | ||
| tuple val(meta2), path(reference_cache, stageAs: 'exomiser_data/*'), val(reference_version) | ||
| tuple val(meta3), path(phenotype_cache, stageAs: 'exomiser_data/*'), val(phenotype_version) |
Member
There was a problem hiding this comment.
This stuff looks reasonable to me, I don't really have a better idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC module PR for
exomiser.I'd like some more eyes on this before I put more time towards it to figure out what's the best way to handle reference data and inputs.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda