BugFix - Use Correct Download Attribute#15074
Closed
alperozturk96 wants to merge 5 commits intomasterfrom
Closed
Conversation
9e00615 to
c38a4d2
Compare
1595425 to
7076746
Compare
7076746 to
b394698
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
3fc7908 to
cdc7cd1
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15074.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15074-Screenshot-blue-Light-07-27 |
Collaborator
Author
|
replaced via #15107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Library PR: nextcloud/android-library#1758
Issue
Since Nextcloud 30, the enabled key have been renamed to value and supports more than boolean. Thus, client needs to support both type.
Documentation
How to test?
Scenario 1: Updating an Existing Share
Scenario 2: Creating a Share with Specific Permissions