Remove share attributes & use OCShare extensions

[alperozturk96]

Client PR: nextcloud/android#15074

Issue

Since Nextcloud 30, the enabled key have been renamed to value and supports more than boolean.

Introducing a generic data class to handle both variations of the JSONArray adds unnecessary complexity when creating or updating the download attribute of a share. Instead, we can simplify the implementation by directly constructing a JsonArray with JsonObject elements, while still providing the same functionality.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 42.85%. Comparing base (ccc7ae5) to head (0303be5).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
...b/resources/shares/extensions/OCShareExtensions.kt	0.00%	27 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1758      +/-   ##
============================================
- Coverage     43.06%   42.85%   -0.22%     
+ Complexity      987      981       -6     
============================================
  Files           235      233       -2     
  Lines          8569     8574       +5     
  Branches       1123     1127       +4     
============================================
- Hits           3690     3674      -16     
- Misses         4361     4390      +29     
+ Partials        518      510       -8     

Files with missing lines	Coverage Δ
...b/resources/shares/extensions/OCShareExtensions.kt	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[alperozturk96]

This cannot be implemented as an extension, as the share object does not exist at the time of share creation. Therefore, optional attributes should be passed as a string parameter instead.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

[AndyScherzinger]

LGTM