Add missing max_amount parameter to settle_permissions in AP2 integration docs#107
Draft
Add missing max_amount parameter to settle_permissions in AP2 integration docs#107
Conversation
Fix 8 documentation issues found during Round 4 evaluation:
- Replace Payments({...}) with Payments.get_instance(PaymentOptions(...)) in MCP Python example
- Replace deprecated facilitator.settle()/verify() with settle_permissions()/verify_permissions()
- Fix query-agents.mdx: reference payment-signature header instead of Authorization
- Fix mcp.mdx: clarify payment token references (not Authorization tokens)
- Fix google-a2a.mdx: use canonical import from payments_py import Payments, PaymentOptions
- Fix CLI index: nvm plans get -> get-plan, nvm x402 get-token -> x402token get-x402-access-token
- Remove non-existent nvm agents list command
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Co-authored-by: aaitor <1726644+aaitor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deprecated APIs and CLI commands in documentation
Add missing max_amount parameter to settle_permissions in AP2 integration docs
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
settle_permissionscall in the AP2/A2A integration example was missing the requiredmax_amountparameter, which would cause runtime errors.Changes:
max_amount="2"to match theNVM_PAYMENT_AMOUNTconfig value shown in the same documentBefore:
After:
This aligns with the pattern used throughout the rest of the Python SDK documentation where
max_amountis a required string parameter specifying credits to burn during settlement.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.