Skip to content

Comments

fix(docs): Round 4 — correct deprecated APIs, field names, and CLI commands#106

Merged
aaitor merged 2 commits intomainfrom
fix/round4-docs
Feb 12, 2026
Merged

fix(docs): Round 4 — correct deprecated APIs, field names, and CLI commands#106
aaitor merged 2 commits intomainfrom
fix/round4-docs

Conversation

@aaitor
Copy link
Member

@aaitor aaitor commented Feb 12, 2026

Summary

  • Fix 8 documentation issues across integration guides, development guides, and CLI reference
  • Replace Payments({...}) with Payments.get_instance(PaymentOptions(...)) in MCP Python example
  • Replace deprecated facilitator.settle()/facilitator.verify() with settle_permissions()/verify_permissions()
  • Fix query-agents.mdx: reference payment-signature header instead of Authorization header
  • Fix mcp.mdx: clarify payment token references (not Authorization tokens)
  • Fix google-a2a.mdx: use canonical import from payments_py import Payments, PaymentOptions
  • Fix CLI commands: nvm plans getget-plan, nvm x402 get-tokennvm x402token get-x402-access-token
  • Remove non-existent nvm agents list command

Test plan

  • Verify no grep hits for deprecated patterns: facilitator.verify(, facilitator.settle(, Payments({
  • Verify CLI commands match actual files in payments/cli/src/commands/
  • Run mintlify build to validate docs

🤖 Generated with Claude Code

Fix 8 documentation issues found during Round 4 evaluation:
- Replace Payments({...}) with Payments.get_instance(PaymentOptions(...)) in MCP Python example
- Replace deprecated facilitator.settle()/verify() with settle_permissions()/verify_permissions()
- Fix query-agents.mdx: reference payment-signature header instead of Authorization
- Fix mcp.mdx: clarify payment token references (not Authorization tokens)
- Fix google-a2a.mdx: use canonical import from payments_py import Payments, PaymentOptions
- Fix CLI index: nvm plans get -> get-plan, nvm x402 get-token -> x402token get-x402-access-token
- Remove non-existent nvm agents list command

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aaitor aaitor requested a review from a team as a code owner February 12, 2026 15:05
Copilot AI review requested due to automatic review settings February 12, 2026 15:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes 8 documentation issues related to deprecated APIs, incorrect header names, wrong import patterns, and outdated CLI command references across integration guides, development guides, and CLI reference documentation.

Changes:

  • Replace deprecated facilitator.verify()/facilitator.settle() with verify_permissions()/settle_permissions()
  • Update Python initialization pattern from Payments({...}) to Payments.get_instance(PaymentOptions(...))
  • Consolidate Python imports to canonical pattern: from payments_py import Payments, PaymentOptions
  • Correct x402 protocol header references from Authorization to payment-signature
  • Update CLI commands to match actual command names (e.g., nvm plans getnvm plans get-plan, nvm x402 get-tokennvm x402token get-x402-access-token)
  • Remove nvm agents list command from CLI quick reference
  • Update Claude Code skill installation instructions
  • Add documentation guidelines about not modifying API reference docs directly

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/products/x402-facilitator/payment-models.mdx Updates Python dynamic pricing example to use settle_permissions() with correct parameters
docs/integrations/nevermined-x402-ap2.mdx Updates facilitator verification and settlement to use new API methods
docs/integrations/mcp.mdx Fixes Python initialization pattern and clarifies payment token references (not Authorization tokens)
docs/integrations/google-a2a.mdx Consolidates Python imports to canonical pattern
docs/integrate/patterns/charge-credits.mdx Updates variable credit charging example to use settle_permissions()
docs/development-guide/query-agents.mdx Corrects header name from Authorization to payment-signature for x402 protocol
docs/development-guide/build-using-nvm-skill.mdx Replaces simple claude /install-skill command with manual git sparse-checkout instructions
docs/api-reference/cli/index.md Updates CLI command names and removes nvm agents list from quick reference
CLAUDE.md Adds notes about API reference docs being sourced from external repos

Comment on lines +103 to +106
payments.facilitator.settle_permissions(
payment_required=payment_required,
x402_access_token=access_token,
)
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settle_permissions call is missing the required max_amount parameter. According to the x402 protocol documentation and the Nevermined Payments API, max_amount is a required parameter that specifies how many credits to burn during settlement. Add max_amount=str(credits_used) to the function call.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link

Copilot AI commented Feb 12, 2026

@aaitor I've opened a new pull request, #107, to work on those changes. Once the pull request is ready, I'll request review from you.

@aaitor aaitor merged commit d31b335 into main Feb 12, 2026
3 checks passed
@aaitor aaitor deleted the fix/round4-docs branch February 12, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants