Skip to content

chore: quote node 24 forces flag and document usage #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neverinfamous merged 1 commit into from
Apr 6, 2026
Merged

chore: quote node 24 forces flag and document usage #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ on:
branches: [main]

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based GitHub Actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

permissions:
contents: write
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ on:
env:
REGISTRY: docker.io
IMAGE_NAME: writenotenow/do-manager
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based GitHub Actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

permissions:
contents: read
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/secrets-scanning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ on:
branches: [main]

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based GitHub Actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
Comment on lines 9 to +11
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 as a quoted string at the workflow env level, but the GITLEAKS Secret Scanning step still sets the same variable to an unquoted boolean (true). This is inconsistent with the stated goal of coercing booleans to strings, and the step-level env is also redundant since the workflow-level env already applies to all steps. Consider removing the step-level override or updating it to the same quoted string value.

Copilot uses AI. Check for mistakes.

permissions:
contents: read
Expand Down
Loading