Skip to content

chore: quote node 24 forces flag and document usage#86

Merged
neverinfamous merged 1 commit intomainfrom
fix/workflow-env-strings
Apr 6, 2026
Merged

chore: quote node 24 forces flag and document usage#86
neverinfamous merged 1 commit intomainfrom
fix/workflow-env-strings

Conversation

@neverinfamous
Copy link
Copy Markdown
Owner

Addresses Copilot AI review by coercing boolean to string and adding explanatory comments.

@neverinfamous neverinfamous enabled auto-merge (squash) April 6, 2026 13:26
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
do-manager be9782a Apr 06 2026, 01:27 PM

Copilot AI review requested due to automatic review settings April 6, 2026 13:26
@neverinfamous neverinfamous merged commit c2519e1 into main Apr 6, 2026
11 checks passed
@neverinfamous neverinfamous deleted the fix/workflow-env-strings branch April 6, 2026 13:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to explicitly set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable as a quoted string and documents why it’s present, aligning with the intent to avoid YAML boolean coercion pitfalls.

Changes:

  • Added an explanatory comment for FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 in multiple workflows.
  • Changed FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 from YAML boolean true to string "true" at the workflow env level.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/secrets-scanning.yml Quotes the Node 24 forcing flag and adds documentation (but still contains a step-level unquoted boolean override).
.github/workflows/docker-publish.yml Quotes the Node 24 forcing flag and adds documentation.
.github/workflows/auto-release.yml Quotes the Node 24 forcing flag and adds documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 9 to +11
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
# Force JavaScript-based GitHub Actions in this workflow to run on Node 24.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 as a quoted string at the workflow env level, but the GITLEAKS Secret Scanning step still sets the same variable to an unquoted boolean (true). This is inconsistent with the stated goal of coercing booleans to strings, and the step-level env is also redundant since the workflow-level env already applies to all steps. Consider removing the step-level override or updating it to the same quoted string value.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants