chore: quote node 24 forces flag and document usage#86
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
do-manager | be9782a | Apr 06 2026, 01:27 PM |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to explicitly set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable as a quoted string and documents why it’s present, aligning with the intent to avoid YAML boolean coercion pitfalls.
Changes:
- Added an explanatory comment for
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24in multiple workflows. - Changed
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24from YAML booleantrueto string"true"at the workflowenvlevel.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/secrets-scanning.yml | Quotes the Node 24 forcing flag and adds documentation (but still contains a step-level unquoted boolean override). |
| .github/workflows/docker-publish.yml | Quotes the Node 24 forcing flag and adds documentation. |
| .github/workflows/auto-release.yml | Quotes the Node 24 forcing flag and adds documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||
| # Force JavaScript-based GitHub Actions in this workflow to run on Node 24. | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" |
There was a problem hiding this comment.
This workflow now sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 as a quoted string at the workflow env level, but the GITLEAKS Secret Scanning step still sets the same variable to an unquoted boolean (true). This is inconsistent with the stated goal of coercing booleans to strings, and the step-level env is also redundant since the workflow-level env already applies to all steps. Consider removing the step-level override or updating it to the same quoted string value.
Addresses Copilot AI review by coercing boolean to string and adding explanatory comments.