[MNT] Disable authentication by default

[alyssadai]

• Closes Change default value of NB_ENABLE_AUTH to False #226
• Related to [MNT] Change default value of NB_ENABLE_AUTH to False #530 api#533

Changes proposed in this pull request:

• Disable auth for API by default when NB_ENABLE_AUTH environment variable is unset
• Remove leftover warning filter in test that is no longer needed after [MNT] Standardize warnings and error logging using logger #228

Checklist

This section is for the PR reviewer

• PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
• PR has a label for the release changelog or skip-release (to be applied by maintainers only)
• PR links to GitHub issue with mention Closes #XXXX
• Tests pass
• Checks pass

For new features:

• Tests have been added

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

Set API authentication to be disabled by default and clean up related tests.

Bug Fixes:

• Ensure missing client ID does not cause errors when authentication is disabled by default.

Enhancements:

• Change default authentication configuration to be disabled unless explicitly enabled via NB_ENABLE_AUTH.
• Add a test to verify the default authentication and client ID settings.

Tests:

• Add a test for default authentication settings and remove an obsolete warning filter from an existing security test.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Default authentication behavior is changed to be disabled unless explicitly enabled via NB_ENABLE_AUTH, and tests are updated to validate the new defaults and remove an obsolete warning filter.

Flow diagram for NB_ENABLE_AUTH-based authentication toggle

flowchart TD
  A[Start_API_process] --> B[Read_environment_variable_NB_ENABLE_AUTH]
  B --> C{Is_NB_ENABLE_AUTH_set?}
  C -- No_unset --> D[Use_default_value_False]
  C -- Yes_set --> E[Convert_value_to_lowercase]
  D --> F[AUTH_ENABLED_is_False]
  E --> G{Value_equals_string_true?}
  G -- Yes --> H[AUTH_ENABLED_is_True]
  G -- No --> F

  subgraph Request_handling
    I[Incoming_API_request] --> J{AUTH_ENABLED_is_True?}
    J -- Yes --> K[Enforce_authentication_and_validate_token]
    J -- No --> L[Bypass_authentication_checks]
    K --> M[Return_response]
    L --> M
  end

  F --> I
  H --> I

Loading

File-Level Changes

Change	Details	Files
Change default authentication configuration to be opt-in via environment variable.	Update AUTH_ENABLED so that it defaults to False when NB_ENABLE_AUTH is unset or not explicitly set to 'true'. Leave CLIENT_ID environment-based configuration unchanged. Retain existing Auth0 JWKS URL and related constants without modification.	app/api/security.py
Extend security tests to cover new default auth behavior and clean up obsolete warning filter.	Add a test ensuring AUTH_ENABLED is False and CLIENT_ID is None by default, with a note about future robustness improvements. Keep existing tests for behavior when auth is enabled and missing client ID, relying on fixtures/env overrides. Remove a now-unnecessary pytest warning filter that suppressed unrelated startup warnings from a test.	tests/test_security.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#226	Set default value of internal variable AUTH_ENABLED to False when NB_ENABLE_AUTH environment variable is unset.	✅

Possibly linked issues

• Change default value of NB_ENABLE_AUTH to False #226: The PR changes AUTH_ENABLED to default False when NB_ENABLE_AUTH is unset, directly implementing the issue’s request.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine

[surchs]

Thanks @alyssadai for the quick fix!

🧑‍🍳

[neurobagel-bot]

🚀 PR was released in v0.8.1 🚀

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.17%. Comparing base (2116354) to head (ebfce8c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   98.37%   98.17%   -0.20%     
==========================================
  Files          30       30              
  Lines         984      987       +3     
==========================================
+ Hits          968      969       +1     
- Misses         16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.