Skip to content

The single quote breaks the strings in Android. We should escape them #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctarabusi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

The single quote breaks the strings in Android. We should escape them #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ba087
The single quote breaks the strings in Android. We should escape them
Mar 31, 2016
bc97884
Removed unnecessary curly braces
Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/babelish/csv2android.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def language_filepaths(language)

def process_value(row_value, default_value)
value = super(row_value, default_value)
# if the value begins and ends with a quote we must leave them unescapted
value.gsub!(/'/, "'" => "\\'") # escape single quote only for Android
# if the value begins and ends with a quote we must leave them unescaped
if value.size > 4 && value[0, 2] == "\\\"" && value[value.size - 2, value.size] == "\\\""
value[0, 2] = "\""
value[value.size - 2, value.size] = "\""
Expand Down