Fix multiple open issues: logging, peer deps, addTransporter, CSS inline bundling, MJML docs#1252
Draft
Fix multiple open issues: logging, peer deps, addTransporter, CSS inline bundling, MJML docs#1252
Conversation
Co-authored-by: juandav <12274145+juandav@users.noreply.github.com>
- Fix verifyTransporter log level from debug to log (#1239) - Add peerDependenciesMeta for optional deps like template engines (#1244) - Fix addTransporter to use createTransporter for consistency (#1234) - Lazy-load @css-inline/css-inline to fix webpack bundling (#1095) - Improve MJML documentation with inlineCssEnabled explanation (#1246) Co-authored-by: juandav <12274145+juandav@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all existing issues and pull requests
Fix multiple open issues: logging, peer deps, addTransporter, CSS inline bundling, MJML docs
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses several open issues across logging, dependency resolution, code consistency, webpack compatibility, and documentation.
Changes
verifyTransporterlog level (Path: **lib/mailer.service.ts** #1239) — Changed.debug()→.log()so "Transporter is ready" is visible at default log levels instead of silently swallowedOptional peer dependencies (not working with nestjs 11 #1244) — Added
peerDependenciesMetamarking template engines (ejs, handlebars, mjml, pug, liquidjs), their type packages, and preview-email as optional. Fixesnpm installfailures with NestJS 11+ when not all engines are installedaddTransporterconsistency (Hook doesn't run when using custom configure transport #1234) — Refactored to reusecreateTransporter()instead of duplicating transport creation inline. Ensures verification and template adapter init follow the same code path assetupTransporters()Lazy-load
@css-inline/css-inline(Error triggered using mailer and any template adapter combined with a custom webpack.config.js, reporting that dist/css_inline_bg.wasm not found. #1095) — Switched from static top-level import torequire()at call site in handlebars, ejs, and pug adapters. The.wasmdependency is now only resolved when CSS inlining actually executes, fixing webpack bundling errorsMJML documentation (Documentation is a mess #1246) — Clarified why
inlineCssEnabled: falseis required (MJML handles its own CSS inlining) and added note on Handlebars partials with MJMLExample: lazy CSS inline loading
Not addressed (out of scope)
optionalDependenciesalready targets mjml 5.x💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.