Skip to content

[Snyk] Upgrade axios from 1.6.4 to 1.12.2 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade axios from 1.6.4 to 1.12.2 #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions course-04/project/c4-final-project-starter-code/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"axios": "^1.6.4",
"axios": "^1.12.2",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This pull request is missing the update to package-lock.json. After changing a dependency version in package.json, it's crucial to run npm install to update the lock file and commit it.

Without the updated package-lock.json, environments that use npm ci (which is common in CI/CD pipelines) will not install the new version of axios. This would mean the security vulnerabilities this PR aims to fix will persist in those environments.

Action required: Please run npm install and commit the updated package-lock.json file to this PR.

"dateformat": "^3.0.3",
"immutability-helper": "^3.0.0",
"react": "^17.0.2",
Expand All @@ -23,7 +23,7 @@
"@types/react-router-dom": "^5.1.8",
"@types/styled-components": "^5.1.11",
"auth0-js": "^9.16.2",
"axios": "^1.6.4",
"axios": "^1.12.2",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The axios package is also listed in the dependencies section (line 6). It is redundant to have a package in both dependencies and devDependencies.

According to npm documentation, devDependencies are for packages only needed for local development and testing. Since axios is used for making API calls in the application's runtime code (as seen in src/api/todos-api.ts), it correctly belongs in dependencies.

Please remove the axios entry from devDependencies to improve maintainability and avoid potential dependency resolution issues. After removing this line, please run npm install again to update the package-lock.json file.

"typescript": ">=3.8.0"
},
"scripts": {
Expand Down