Skip to content

[Snyk] Upgrade axios from 1.6.4 to 1.12.2 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nejidevelops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade axios from 1.6.4 to 1.12.2 #689

nejidevelops wants to merge 1 commit into from

Conversation

@nejidevelops
Copy link
Owner

@nejidevelops nejidevelops commented Oct 8, 2025

snyk-top-banner

Snyk has created this PR to upgrade axios from 1.6.4 to 1.12.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

  • The recommended version is 28 versions ahead of your current version.

  • The recommended version was released 24 days ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574		 362 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574		 362 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-7361793		 362 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860		 362 No Known Exploit
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727		 362 Proof of Concept
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-CROSSSPAWN-8303230		 362 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906		 362 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-ROLLUP-8073097		 362 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-WEBPACK-7840298		 362 Proof of Concept
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-AXIOS-12613773		 362 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9292519		 362 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9403194		 362 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELHELPERS-9397697		 362 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504		 362 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060		 362 No Known Exploit
medium severity Improper Control of Dynamically-Managed Code Resources
SNYK-JS-EJS-6689533		 362 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509		 362 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867		 362 No Known Exploit
medium severity Always-Incorrect Control Flow Implementation
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387		 362 No Known Exploit
medium severity Improper Check for Unusual or Exceptional Conditions
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389		 362 No Known Exploit
medium severity Cross-site Scripting (XSS)
SNYK-JS-JQUERY-565129		 362 Mature
medium severity Cross-site Scripting (XSS)
SNYK-JS-JQUERY-567880		 362 Mature
medium severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728		 362 No Known Exploit
medium severity Improper Input Validation
SNYK-JS-NANOID-8492085		 362 No Known Exploit
medium severity Improper Handling of Unexpected Data Type
SNYK-JS-ONHEADERS-10773729		 362 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106		 362 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106		 362 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416		 362 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862		 362 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865		 362 No Known Exploit
low severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BRACEEXPANSION-9789073		 362 Proof of Concept
low severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BRACEEXPANSION-9789073		 362 Proof of Concept
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150		 362 Proof of Concept
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150		 362 Proof of Concept
Release notes
Package name: axios from axios GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

@snyk-bot
fix: upgrade axios from 1.6.4 to 1.12.2
3bbc9d3 
Snyk has created this PR to upgrade axios from 1.6.4 to 1.12.2.

See this package in npm:
axios

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/19b6a92b-035b-448e-900c-0cc8b1ce86e5?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 8, 2025

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the axios dependency from 1.6.4 to 1.12.2 in the client-side package.json to address numerous security vulnerabilities, including high and critical severity issues. The upgrade incorporates 28 versions of axios with various bug fixes and new features. Reviewers should confirm compatibility and test for regressions.

Highlights

  • Intent: This pull request, automatically generated by Snyk, aims to upgrade the axios dependency from version 1.6.4 to 1.12.2. The primary goal is to keep dependencies up-to-date, which helps in fixing existing vulnerabilities and quickly identifying new ones.
  • Key Changes: The axios package version has been updated in course-04/project/c4-final-project-starter-code/client/package.json. Specifically, the version in both dependencies and devDependencies sections has been changed from ^1.6.4 to ^1.12.2.
  • Vulnerability Fixes: This upgrade addresses a significant number of security vulnerabilities across various packages, including axios itself and other indirect dependencies. These include multiple high-severity Denial of Service (DoS) and Server-side Request Forgery (SSRF) issues, several medium-severity Cross-site Scripting (XSS) and Regular Expression Denial of Service (ReDoS) issues, and critical-severity Predictable Value Range from Previous Values issues. A total of 34 vulnerabilities are listed as fixed by this upgrade.
  • Release Notes: The upgrade spans 28 versions of axios, with the target version 1.12.2 released 24 days ago. The release notes for versions 1.12.2, 1.12.1, 1.12.0, 1.11.0, 1.10.0, 1.9.0, 1.8.4, and 1.8.3 are provided, detailing various bug fixes (e.g., fetch adapter issues, type fixes, form-data handling) and new features (e.g., surface low-level network error details, fetch environment config, AxiosHeaders.getSetCookie method).
  • Reviewer Notes: Reviewers should verify that the updated axios version (1.12.2) does not introduce any breaking changes or regressions in the client-side application, especially given the jump across 28 minor versions. Although Snyk indicates no breaking changes, it's prudent to ensure compatibility with existing code that uses axios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 8, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades axios to fix several security vulnerabilities. While the version bump in package.json is correct, there are two important issues to address:

  1. package-lock.json is not updated: This is a critical omission that could prevent the security fix from being applied in CI/CD environments.
  2. Redundant Dependency: axios is listed in both dependencies and devDependencies, which should be corrected for better maintainability.

Please see the detailed comments on the specific lines.

course-04/project/c4-final-project-starter-code/client/package.json
"private": true,
"dependencies": {
"axios": "^1.6.4",
"axios": "^1.12.2",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This pull request is missing the update to package-lock.json. After changing a dependency version in package.json, it's crucial to run npm install to update the lock file and commit it.

Without the updated package-lock.json, environments that use npm ci (which is common in CI/CD pipelines) will not install the new version of axios. This would mean the security vulnerabilities this PR aims to fix will persist in those environments.

Action required: Please run npm install and commit the updated package-lock.json file to this PR.

course-04/project/c4-final-project-starter-code/client/package.json
"@types/styled-components": "^5.1.11",
"auth0-js": "^9.16.2",
"axios": "^1.6.4",
"axios": "^1.12.2",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The axios package is also listed in the dependencies section (line 6). It is redundant to have a package in both dependencies and devDependencies.

According to npm documentation, devDependencies are for packages only needed for local development and testing. Since axios is used for making API calls in the application's runtime code (as seen in src/api/todos-api.ts), it correctly belongs in dependencies.

Please remove the axios entry from devDependencies to improve maintainability and avoid potential dependency resolution issues. After removing this line, please run npm install again to update the package-lock.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nejidevelops @snyk-bot