Skip to content

Open Source Draco Release#117

Merged
dzbaker merged 2 commits intomainfrom
draco-integration
Jan 23, 2026
Merged

Open Source Draco Release#117
dzbaker merged 2 commits intomainfrom
draco-integration

Conversation

@dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Jan 15, 2026 •
edited
Loading

NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"
Batch update of latest cFS software release

Reflects commit 21682bfa91327396b023fb8a27391af4e55812d3 from NASA internal development repo

@jphickey
NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"
f43f043 
Batch update of latest cFS software release

Reflects commit 21682bfa91327396b023fb8a27391af4e55812d3 from NASA internal development repo
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2026
View reviewed changes
config/default_lc_fcncode_values.h
* Macro Definitions
************************************************************************/

#define LC_CCVAL(x) LC_FunctionCode_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro LC_CCVAL(x) uses token pasting and is not allowed.
config/default_lc_interface_cfg_values.h
#define DEFAULT_LC_INTERFACE_CFG_VALUES_H

/* Use the default configuration value for all */
#define LC_INTERFACE_CFGVAL(x) DEFAULT_LC_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro LC_INTERFACE_CFGVAL(x) uses token pasting and is not allowed.
config/default_lc_internal_cfg_values.h
#define DEFAULT_LC_INTERNAL_CFG_VALUES_H

/* Use the default configuration value for all */
#define LC_INTERNAL_CFGVAL(x) DEFAULT_LC_##x

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro LC_INTERNAL_CFGVAL(x) uses token pasting and is not allowed.
config/default_lc_msgid_values.h
#include "lc_topicids.h"
#include "cfe_core_api_base_msgids.h"

#define LC_CMD_PLATFORM_MIDVAL(x) CFE_PLATFORM_CMD_TOPICID_TO_MIDV(LC_MISSION_##x##_TOPICID)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro LC_CMD_PLATFORM_MIDVAL(x) uses token pasting and is not allowed.
config/default_lc_msgid_values.h
#include "cfe_core_api_base_msgids.h"

#define LC_CMD_PLATFORM_MIDVAL(x) CFE_PLATFORM_CMD_TOPICID_TO_MIDV(LC_MISSION_##x##_TOPICID)
#define LC_TLM_PLATFORM_MIDVAL(x) CFE_PLATFORM_TLM_TOPICID_TO_MIDV(LC_MISSION_##x##_TOPICID)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro LC_TLM_PLATFORM_MIDVAL(x) uses token pasting and is not allowed.
fsw/src/lc_cmds.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void LC_ResetWPStatsCmd(const CFE_SB_Buffer_t *BufPtr)
CFE_Status_t LC_ResetWPStatsCmd(const LC_ResetWPStatsCmd_t *msg)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/lc_dispatch.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
bool LC_VerifyMsgLength(const CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength)
bool LC_VerifyMsgLength(const CFE_MSG_Message_t *msgPtr, size_t ExpectedLength)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/lc_dispatch.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
bool LC_VerifyMsgLength(const CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength)
bool LC_VerifyMsgLength(const CFE_MSG_Message_t *msgPtr, size_t ExpectedLength)

Check notice

Code scanning / CodeQL

Function too long Note

LC_VerifyMsgLength has too many lines (66, while 60 are allowed).
fsw/src/lc_dispatch.c
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t LC_AppPipe(const CFE_SB_Buffer_t *BufPtr)
void LC_AppProcessCmd(const CFE_SB_Buffer_t *BufPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/lc_dispatch.c
/* Process a command pipe message */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void LC_AppPipe(const CFE_SB_Buffer_t *BufPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@jphickey jphickey marked this pull request as ready for review January 23, 2026 12:43
@dzbaker dzbaker merged commit 4cc95d7 into main Jan 23, 2026
13 checks passed
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jphickey jphickey jphickey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dzbaker @jphickey