feat: add nabledge-1.x knowledge generation infrastructure (#189)#200
Closed
feat: add nabledge-1.x knowledge generation infrastructure (#189)#200
Conversation
Add skill scaffolding, mappings, and source catalog cache for Nablarch 1.x versions (1.2, 1.3, 1.4). Extend knowledge-creator scripts and tests to support v1.x version handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing: implementation contained unverified assumptions. Will redo after confirming v1.x nablarch-document structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189
Approach
Add infrastructure to run
kc.sh gen 1.4,kc.sh gen 1.3, andkc.sh gen 1.2for Nablarch 1.x legacy versions. Key design: two-path fallback for RST source discovery (nablarch-document/first, then{version}_maintain/symlink), consistent with the v5/v6 approach but extending to legacy version naming conventions. All changes are backward-compatible — v5/v6 pipelines are unaffected.Tasks
.claude/skills/nabledge-1.4/,.claude/skills/nabledge-1.3/,.claude/skills/nabledge-1.2/(SKILL.md, plugin.json, CHANGELOG.md).cache/v1.4/catalog.json,.cache/v1.3/catalog.json,.cache/v1.2/catalog.jsonmappings/v1.4.json,mappings/v1.3.json,mappings/v1.2.jsonrun.pyto accept--version 1.4,1.3,1.2in choicesstep1_list_sources.pywith two-path fallback for 1.x RST source discoveryclean.pyto handle v1.x version directoriesclean.pyandkc.shv1.x handlingsetup.sh(auto-create{version}_maintainsymlinks after clone)README.mdExpert Review
AI-driven expert reviews conducted before PR creation (see
.claude/rules/expert-review.md):Success Criteria Check
.lw/nab-official/v1.4/1.4_maintain,.lw/nab-official/v1.3/1.3_maintain,.lw/nab-official/v1.2/1.2_maintainsetup.shauto-creates symlinks after cloning; documented in README.md--version 1.4,--version 1.3,--version 1.2run.pychoices updated to include"1.4","1.3","1.2"(line 118)kc.shpasses 1.x versions through torun.pycorrectlykc.shversion passthrough verified; unit tests intests/ut/test_kc_sh.py.cache/v1.4/catalog.json,.cache/v1.3/catalog.json,.cache/v1.2/catalog.jsonmappings/v1.4.json,mappings/v1.3.json,mappings/v1.2.json.claude/skills/nabledge-1.4/,.claude/skills/nabledge-1.3/,.claude/skills/nabledge-1.2/tests/e2e/test_e2e.pycovering all three versionskc.sh gen 1.4 --dry-runcompletes without errorREADME.mddocuments directory structure;setup.shauto-creates symlinks🤖 Generated with Claude Code