-
Notifications
You must be signed in to change notification settings - Fork 1
feat: set up nabledge-1.x knowledge generation infrastructure (#189) #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiyotis
wants to merge
16
commits into
main
Choose a base branch
from
189-setup-nabledge-1x-infra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e274b4
docs: document Nablarch 1.x symlink setup for knowledge file generati…
kiyotis ca6917b
docs: clarify 1.x symlink setup as user-run commands, not Claude Code
kiyotis d889950
feat: make knowledge-creator pipeline version-aware for v1.x
kiyotis 4a9ff74
test: add v1.4/1.3/1.2 E2E test fixtures (failing until mapping aligned)
kiyotis 1c92a93
feat: create nabledge-1.x skill structures and catalog stubs
kiyotis 042ccab
docs: add v1.4 directory-to-mapping analysis for review
kiyotis acbc7e2
docs: add full RST-to-mapping table for v1.4 review response
kiyotis 786cab5
docs: trim 1.4-mappings.md to RST file listing table only
kiyotis 32ba6fd
docs: mark non-existing categories with × in 1.4 mapping table
kiyotis 48e1f34
docs: review and correct type/category assignments in 1.4 mapping table
kiyotis d464f6a
feat: add v1.4 multi-repo support and mapping table for workflow/biz_…
kiyotis 7fa049d
docs: fix type/category assignments based on review feedback
kiyotis f565f99
docs: add non-RST user-readable files (Office/PDF) to 1.4 mapping table
kiyotis 855d01f
docs: rebuild 1.4 mapping table based on v1.4-dist user-viewable files
kiyotis 764b3c5
fix: correct type/category assignments in 1.4 mapping table and add svn
kiyotis 01c85a4
feat: add v1.4/v1.3/v1.2 mapping files and fix multi-repo path handling
kiyotis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # 変更履歴 | ||
|
|
||
| nabledge-1.2プラグインの主な変更内容を記録しています。 | ||
|
|
||
| フォーマットは [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) に基づいています。 | ||
|
|
||
| ## [Unreleased] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "name": "nabledge-1.2", | ||
| "version": "0.1", | ||
| "description": "Nablarch 1.2 skill for AI-assisted development", | ||
| "author": { | ||
| "name": "Nablarch" | ||
| }, | ||
| "license": "Apache-2.0", | ||
| "repository": "https://github.com/nablarch/nabledge", | ||
| "keywords": [ | ||
| "nablarch" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # 変更履歴 | ||
|
|
||
| nabledge-1.3プラグインの主な変更内容を記録しています。 | ||
|
|
||
| フォーマットは [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) に基づいています。 | ||
|
|
||
| ## [Unreleased] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "name": "nabledge-1.3", | ||
| "version": "0.1", | ||
| "description": "Nablarch 1.3 skill for AI-assisted development", | ||
| "author": { | ||
| "name": "Nablarch" | ||
| }, | ||
| "license": "Apache-2.0", | ||
| "repository": "https://github.com/nablarch/nabledge", | ||
| "keywords": [ | ||
| "nablarch" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # 変更履歴 | ||
|
|
||
| nabledge-1.4プラグインの主な変更内容を記録しています。 | ||
|
|
||
| フォーマットは [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) に基づいています。 | ||
|
|
||
| ## [Unreleased] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "name": "nabledge-1.4", | ||
| "version": "0.1", | ||
| "description": "Nablarch 1.4 skill for AI-assisted development", | ||
| "author": { | ||
| "name": "Nablarch" | ||
| }, | ||
| "license": "Apache-2.0", | ||
| "repository": "https://github.com/nablarch/nabledge", | ||
| "keywords": [ | ||
| "nablarch" | ||
| ] | ||
| } |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Notes - PR #190 | ||
|
|
||
| ## 2026-03-13 | ||
|
|
||
| ### 現在の作業状況(再開ポイント) | ||
|
|
||
| **未コミットの変更ファイル** (`tools/knowledge-creator/` 配下): | ||
|
|
||
| | ファイル | 状態 | 内容 | | ||
| |---------|------|------| | ||
| | `mappings/v1.4.json` | modified | `document/` prefix を全パターンに追加、sample/portal パターン追加(ID dedup 修正)、レビュー指摘を反映 | | ||
| | `mappings/v1.3.json` | **new (未追跡)** | single-repo パターン(`1.3_maintain/` をストリップ後のパス) | | ||
| | `mappings/v1.2.json` | **new (未追跡)** | single-repo パターン(`1.2_maintain/` をストリップ後のパス) | | ||
| | `scripts/step2_classify.py` | modified | v1.4用条件分岐: `classify_rst`と`generate_id`でrepoマーカーをrel_pathに残す | | ||
| | `tests/e2e/generate_expected.py` | modified | 同上の修正(E2Eテスト期待値生成用) | | ||
|
|
||
| ### 次のステップ | ||
|
|
||
| 1. **E2Eテスト確認**: | ||
| ```bash | ||
| cd tools/knowledge-creator | ||
| python -m pytest tests/e2e/test_e2e.py -k "1.4" -v | ||
| ``` | ||
| 2. 通ったら **全バージョン** も確認: | ||
| ```bash | ||
| python -m pytest tests/e2e/test_e2e.py -v | ||
| ``` | ||
| 3. テスト通過後、全5ファイルをコミット: | ||
| ```bash | ||
| git add tools/knowledge-creator/mappings/v1.4.json \ | ||
| tools/knowledge-creator/mappings/v1.3.json \ | ||
| tools/knowledge-creator/mappings/v1.2.json \ | ||
| tools/knowledge-creator/scripts/step2_classify.py \ | ||
| tools/knowledge-creator/tests/e2e/generate_expected.py | ||
| git commit -m "feat: add v1.4/v1.3/v1.2 mapping files and fix multi-repo path handling" | ||
| ``` | ||
| 4. Push して PR #190 のレビューコメントに返信 | ||
|
|
||
| ### 重要な設計判断(絶対に戻さないこと) | ||
|
|
||
| **v1.4 multi-repo パス処理**: | ||
| - `step2_classify.py`: v1.4 のみ `rel_path = marker + path[idx + len(marker):]`(`document/`, `workflow/` 等のprefixを保持) | ||
| - v5/v6 の後方互換を保つため `if self.ctx.version == "1.4":` で条件分岐 | ||
| - `v1.4.json` のパターンはrepoプレフィックス付き(例: `document/FAQ/batch/`) | ||
| - `v1.2.json` / `v1.3.json` のパターンはプレフィックスなし(single-repo、マーカーストリップ後のパス) | ||
|
|
||
| ### テストが失敗していた経緯 | ||
|
|
||
| - 最初: v1.4.json のパターンが `FAQ/batch/`(prefixなし)→ 117ファイル未マッピング | ||
| - 修正1: step2_classify.py でマーカーを保持 + v1.4.json に `document/` prefix 追加 | ||
| - 修正2: `sample/portal/src/source/faq/*` のIDデデュップ失敗 → 個別パターン追加 | ||
| - 修正3: session-scoped fixture が v1.3.json を要求 → v1.3.json / v1.2.json 新規作成 | ||
| - 現状: v1.3.json/v1.2.json 作成済み、テスト実行中(セッション終了のため結果未確認) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "version": "1.2", | ||
| "base_doc_url": "", | ||
| "generated_at": "", | ||
| "sources": [ | ||
| { | ||
| "repo": "local", | ||
| "branch": "local", | ||
| "commit": "" | ||
| } | ||
| ], | ||
| "files": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "version": "1.3", | ||
| "base_doc_url": "", | ||
| "generated_at": "", | ||
| "sources": [ | ||
| { | ||
| "repo": "local", | ||
| "branch": "local", | ||
| "commit": "" | ||
| } | ||
| ], | ||
| "files": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "version": "1.4", | ||
| "base_doc_url": "", | ||
| "generated_at": "", | ||
| "sources": [ | ||
| { | ||
| "repo": "local", | ||
| "branch": "local", | ||
| "commit": "" | ||
| } | ||
| ], | ||
| "files": [] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "rst": [ | ||
| {"pattern": "FAQ/batch/", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "FAQ/test/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "FAQ/validation/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "FAQ/web/", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "FAQ/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "TOP/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "fw/handler/", "type": "component", "category": "handlers"}, | ||
| {"pattern": "fw/reader/", "type": "component", "category": "readers"}, | ||
| {"pattern": "fw/core_library/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/common_library/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/02_FunctionDemandSpecifications/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/architectural_pattern/batch", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "fw/architectural_pattern/messaging_http", "type": "processing-pattern", "category": "http-messaging"}, | ||
| {"pattern": "fw/architectural_pattern/messaging", "type": "processing-pattern", "category": "mom-messaging"}, | ||
| {"pattern": "fw/architectural_pattern/web_gui", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "fw/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "guide/05_UnitTestGuide/02_RequestUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/03_DealUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/01_ClassUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/06_TestFWGuide/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/08_TestTools/04_JspStaticAnalysis/", "type": "development-tools", "category": "java-static-analysis"}, | ||
| {"pattern": "guide/08_TestTools/05_JavaStaticAnalysis/", "type": "development-tools", "category": "java-static-analysis"}, | ||
| {"pattern": "guide/08_TestTools/", "type": "development-tools", "category": "toolbox"}, | ||
| {"pattern": "guide/02_UnitTestOutline/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/03_DevelopmentStep/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/04_Explanation_batch/", "type": "guide", "category": "nablarch-batch"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_delayed_receive/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_delayed_send/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_http_real/", "type": "guide", "category": "http-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_http_send_sync/", "type": "guide", "category": "http-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_real/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_send_sync/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_other/04_Explanation_mail/", "type": "guide", "category": "libraries"}, | ||
| {"pattern": "guide/04_Explanation_other/", "type": "guide", "category": "libraries"}, | ||
| {"pattern": "guide/04_Explanation/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/20_Appendix/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "sample/portal/src/source/faq/batch/", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "sample/portal/src/source/faq/test/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "sample/portal/src/source/faq/validation/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "sample/portal/src/source/faq/web/", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "sample/portal/src/source/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "sample/portal/doc/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "tool/", "type": "development-tools", "category": "toolbox"} | ||
| ], | ||
| "md": {}, | ||
| "xlsx": {}, | ||
| "xlsx_patterns": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "rst": [ | ||
| {"pattern": "FAQ/batch/", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "FAQ/test/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "FAQ/validation/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "FAQ/web/", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "FAQ/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "TOP/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "fw/handler/", "type": "component", "category": "handlers"}, | ||
| {"pattern": "fw/reader/", "type": "component", "category": "readers"}, | ||
| {"pattern": "fw/core_library/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/common_library/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/02_FunctionDemandSpecifications/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "fw/architectural_pattern/batch", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "fw/architectural_pattern/messaging_http", "type": "processing-pattern", "category": "http-messaging"}, | ||
| {"pattern": "fw/architectural_pattern/messaging", "type": "processing-pattern", "category": "mom-messaging"}, | ||
| {"pattern": "fw/architectural_pattern/web_gui", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "fw/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "guide/05_UnitTestGuide/02_RequestUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/03_DealUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/01_ClassUnitTest/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/05_UnitTestGuide/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/06_TestFWGuide/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/08_TestTools/04_JspStaticAnalysis/", "type": "development-tools", "category": "java-static-analysis"}, | ||
| {"pattern": "guide/08_TestTools/05_JavaStaticAnalysis/", "type": "development-tools", "category": "java-static-analysis"}, | ||
| {"pattern": "guide/08_TestTools/", "type": "development-tools", "category": "toolbox"}, | ||
| {"pattern": "guide/02_UnitTestOutline/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "guide/03_DevelopmentStep/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/04_Explanation_batch/", "type": "guide", "category": "nablarch-batch"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_delayed_receive/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_delayed_send/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_http_real/", "type": "guide", "category": "http-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_http_send_sync/", "type": "guide", "category": "http-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_real/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/04_Explanation_send_sync/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_messaging/", "type": "guide", "category": "mom-messaging"}, | ||
| {"pattern": "guide/04_Explanation_other/04_Explanation_mail/", "type": "guide", "category": "libraries"}, | ||
| {"pattern": "guide/04_Explanation_other/", "type": "guide", "category": "libraries"}, | ||
| {"pattern": "guide/04_Explanation/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/20_Appendix/", "type": "guide", "category": "web-application"}, | ||
| {"pattern": "guide/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "sample/portal/src/source/faq/batch/", "type": "processing-pattern", "category": "nablarch-batch"}, | ||
| {"pattern": "sample/portal/src/source/faq/test/", "type": "development-tools", "category": "testing-framework"}, | ||
| {"pattern": "sample/portal/src/source/faq/validation/", "type": "component", "category": "libraries"}, | ||
| {"pattern": "sample/portal/src/source/faq/web/", "type": "processing-pattern", "category": "web-application"}, | ||
| {"pattern": "sample/portal/src/source/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "sample/portal/doc/", "type": "about", "category": "about-nablarch"}, | ||
| {"pattern": "tool/", "type": "development-tools", "category": "toolbox"} | ||
| ], | ||
| "md": {}, | ||
| "xlsx": {}, | ||
| "xlsx_patterns": [] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svnなんですがコミットハッシュのような値を取れますか?
svnコマンドが必要であればsetup.shにインストールを追加して私に教えてください。setup.shを実行します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認しました。
v1.4 は SVN リポジトリです。
svnコマンドがなくても、Python 標準ライブラリのsqlite3を使って.svn/wc.dbからリビジョン番号を取得できることを確認しました。現在のリビジョンは29166です。ただし、
svnコマンドのインストールについては以下の点を確認させてください:.svn/wc.dbを読み取る方式は実装可能です。ただしこれは非公式の内部実装に依存するアプローチですv1.4 の
catalog.jsonでは現在commitフィールドが空文字で、ソース変更検知(kc regen)には使用していません。SVN リビジョン取得の実装は今回の PR スコープ外になりますが、必要でしょうか?Co-Authored-By: Claude (jp.anthropic.claude-sonnet-4-6) noreply@anthropic.com
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issueのスコープを確認してPRタイトル見直してください。
svnコマンドにしてください。WSL2だとsetup.shでの実現が難しいですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Commit: 764b3c54
setup.shにsubversionを追加しました(apt-get install の対象に追加)。PR タイトルも見直しました。変更内容はドキュメントだけでなく setup.sh・catalog.json・mapping files・skill 構造・run.py・テストを含む infrastructure 全体のセットアップのため、
docs:からfeat:に変更しました:Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Commit: 764b3c54
setup.shの apt-get install にsubversionを追加しました。WSL2 (Ubuntu) ではapt-get install subversionで問題なくインストールできます。PR タイトルを
feat: set up nabledge-1.x knowledge generation infrastructure (#189)に変更しました。Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com