Skip to content

fix: distinguish delimiters in queries from SQL comments#22

Merged
wellwelwel merged 2 commits intomainfrom
backtick
Feb 16, 2026
Merged

fix: distinguish delimiters in queries from SQL comments#22
wellwelwel merged 2 commits intomainfrom
backtick

Conversation

@wellwelwel
Copy link
Member

@wellwelwel wellwelwel commented Feb 16, 2026

Fixes #21, Fixes sidorares/node-mysql2#4083.

Adds a layer to AST to distinguish when delimiters are used inside backticks.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ca998a7) to head (409e2fb).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          386       401   +15     
=========================================
+ Hits           386       401   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel marked this pull request as ready for review February 16, 2026 18:19
@wellwelwel wellwelwel changed the title fix: distinguish double dashes in queries from SQL comments fix: distinguish delimiters in queries from SQL comments Feb 16, 2026
@wellwelwel wellwelwel merged commit 5a11707 into main Feb 16, 2026
11 checks passed
@wellwelwel wellwelwel deleted the backtick branch February 16, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants