Skip to content

fix: distinguish delimiters in queries from SQL comments#4084

Merged
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bt
Feb 16, 2026
Merged

fix: distinguish delimiters in queries from SQL comments#4084
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bt

Conversation

@wellwelwel
Copy link
Copy Markdown
Collaborator

Resolve #4083, already fixed from sql-escaper side in mysqljs/sql-escaper#22.

@wellwelwel wellwelwel added the dependencies Pull requests that update a dependency file label Feb 16, 2026
@wellwelwel wellwelwel changed the title distinguish delimiters in queries from SQL comments fix: distinguish delimiters in queries from SQL comments Feb 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (ce98d8e) to head (38ee9bc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4084   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files          86       86           
  Lines       13663    13663           
  Branches     1634     1634           
=======================================
  Hits        12289    12289           
  Misses       1374     1374           
Flag Coverage Δ
compression-0 89.05% <ø> (ø)
compression-1 89.92% <ø> (ø)
static-parser-0 87.52% <ø> (ø)
static-parser-1 88.28% <ø> (ø)
tls-0 89.35% <ø> (ø)
tls-1 89.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel marked this pull request as ready for review February 16, 2026 18:47
@wellwelwel wellwelwel merged commit 454ba10 into sidorares:master Feb 16, 2026
104 checks passed
@wellwelwel wellwelwel deleted the bt branch February 16, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 3.17.0: double-dash inside backtick-quoted identifiers breaks placeholder substitution

1 participant