Fix IADDAT visualization anchoring to model coordinates instead of periodic images#6
Draft
Fix IADDAT visualization anchoring to model coordinates instead of periodic images#6
Conversation
…ring Co-authored-by: LifeHasOrder <12899220+LifeHasOrder@users.noreply.github.com>
Co-authored-by: LifeHasOrder <12899220+LifeHasOrder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix vector mapping and peak visualization in IADDAT plugin
Fix IADDAT visualization anchoring to model coordinates instead of periodic images
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displacement vectors and density peaks were displayed at shifted unit cell copies rather than around the atomic model. The visualization logic incorrectly used
mark.pos(nearest atom image fromgemmi.NeighborSearch, which may be a periodic copy) as the anchor point.Changes
Map Generation
IADDAT_peaks_tableVector Calculation
coordx,coordy,coordz) instead ofmarkcoordinates incalculate_per_atom_vectorspeak - coordrather thanpeak - markPeak Visualization
coord + deltarelative to model atoms increate_peak_objects_single_modelandcreate_carved_peak_objects_single_modelRemoved Incorrect Symmetry Logic
image_idxfromgemmi.NeighborSearchas space group operationsimage_idxrepresents PBC shifts, not crystallographic symmetry operationsmap_symmetry_features_to_model,extract_symmetry_transformations,apply_inverse_transformations_to_peaks, and related validation functionsOriginal prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.