Update experimenter api environment variable (as part of Android PR) #662
Conversation
✅ Deploy Preview for fxms-skylight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarahhjchung
left a comment
sarahhjchung
left a comment
There was a problem hiding this comment.
I've removed TODO.md and MOBILE-EPICS.md and cleaned up some comments. Overall the changes made to the environment variables look good and I've only made one change to the code!
app/fetchData.ts
Outdated
| const isLookerEnabled = process.env.IS_LOOKER_ENABLED === "true"; | ||
|
|
||
| export async function fetchData(platform: Platform) { | ||
| const recipeCollection = new NimbusRecipeCollection(true, platform); //XXX YYY |
There was a problem hiding this comment.
Setting the first parameter as false instead so that we are showing live experiments and rollouts as it seems we are leaving the completed page as is for now.
| totalRolloutExperiments, | ||
| }; | ||
| } | ||
| export async function getMsgExpRecipeCollection( |
There was a problem hiding this comment.
Adding missing JSDocs for functions in this file to make them more readable
app/types.ts
Outdated
There was a problem hiding this comment.
Removing this empty file
|
@AllegroFox I've added the environment variable to Netlify here. Do you think it makes sense that I only need to add it to the production context? It seems like the deploy previews and local branches are working fine using the |
sarahhjchung
changed the title
That makes sense to me from my understanding of Netlify! |
|
Actually I realized that I also have to add it to the deploy preview context as well as future builds were failing 😅 |
There was a problem hiding this comment.
Is it intentional that this file and copilot-instructions.md have the same contents?
There was a problem hiding this comment.
Based on the commit 374cd7a when these docs were added, they look to be intentionally the same. So I'll leave them as is and confirm with Dan!
| totalRolloutExperiments, | ||
| }; | ||
| } | ||
| export async function getMsgExpRecipeCollection( |
Changes made: