Skip to content

[WIP] Clean up mobile additions to feature ID list #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sarahhjchung wants to merge 40 commits into from
Closed

[WIP] Clean up mobile additions to feature ID list #663

sarahhjchung wants to merge 40 commits into from

Conversation

@sarahhjchung
Copy link
Contributor

@sarahhjchung sarahhjchung commented Apr 15, 2025

Changes made:

dmose added 30 commits April 15, 2025 14:05
@dmose @sarahhjchung
Update TODO list
8b953e2
@dmose @sarahhjchung
Add basic instructions for copilot case sensitivity.
21ecd44
@dmose @sarahhjchung
Refactor page.tsx to call fetchData and pass params
6a0112e
@dmose @sarahhjchung
Fixup Android calling of Dashboard component.
b3b9a94
@dmose @sarahhjchung
Made localData optional to Dashboard component
9e18ede
@dmose @sarahhjchung
Make the file case instructions clearer
e31c39e
@dmose @sarahhjchung
Fixup dashboard test
6f199bb
@dmose @sarahhjchung
Move platform to a union type
487c0c7
@dmose @sarahhjchung
Refactor fetchData to its own file
c5e2a1e
@dmose @sarahhjchung
Renamed fetchData.tsx to fetchData.ts
0340475
@dmose @sarahhjchung
Export compareDatesFn to fix the app
ebe78b0
@dmose @sarahhjchung
Remove obsolete fetchData.tsx
dccc2a0
@dmose @sarahhjchung
Move getASRouterLocalMessageIntoFromFile to fetchData.ts
a85e012
@dmose @sarahhjchung
Move getASRouterLocalColumnFromJSON to fetchData.ts
deef435
@dmose @sarahhjchung
Remove extra copy of getMsgExpRecipeCollection from dashboard.tsx
4ed15b0
@dmose @sarahhjchung
Remove dead code
05e7baa
@dmose @sarahhjchung
Move appendFxMSTelemetryData to fetchData.ts
f95527b
@dmose @sarahhjchung
Move functions to fetchData and clean up
1887313
@dmose @sarahhjchung
Appease prettier
a8c8fbb
@dmose @sarahhjchung
Update comment about fetchData file home
92605cc
@dmose @sarahhjchung
Formatting tweaks
84d2601
@dmose @sarahhjchung
Update TODO list
db42cee
@dmose @sarahhjchung
Flesh out Android standup plan
31dc009
@dmose @sarahhjchung
Minor TODO update
20b3e7a
@dmose @sarahhjchung
Add WIP MOBILE-EPICS list
a9002b1
@dmose @sarahhjchung
Update mobile epics
43a56a8
@dmose @sarahhjchung
Appease prettier
2b3b3c9
@dmose @sarahhjchung
Create platformInfo object
3c89b3b
@dmose @sarahhjchung
Added a test to check for correct URL construction
9465ea5
@dmose @sarahhjchung
Move experiments path component to a more sensible env var
6847744
@netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for fxms-skylight ready!

Name Link
🔨 Latest commit 2af71f8
🔍 Latest deploy log https://app.netlify.com/sites/fxms-skylight/deploys/67fec3fb206cc90008bc3c8a
😎 Deploy Preview https://deploy-preview-663--fxms-skylight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 88 (🔴 down 1 from production)
Best Practices: 83 (no change from production)
SEO: 100 (🟢 up 10 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahhjchung sarahhjchung deleted the feature-id-list branch April 16, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahhjchung @dmose