Skip to content

Gracefully handle non-existance of event_name when trying to get auto-events #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badboy merged 1 commit into from
Aug 11, 2025
Merged

Gracefully handle non-existance of event_name when trying to get auto-events #2311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions etl/glean_auto_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,12 @@ def get_auto_events_for_app(app, auto_events):
event_names = [event for event in auto_events if event["app"] == app]
auto_events = []
for row in event_names:
auto_event_id = row["event_name"].split(".")[-1]
event_name = row.get("event_name")
if not event_name:
continue
auto_event_id = event_name.split(".")[-1]
event_template = copy.deepcopy(_auto_event_template)
event_template["name"] = row["event_name"]
event_template["name"] = event_name
auto_event_type_prefix = event_template["name"].split(".")[1]
if auto_event_type_prefix.startswith("element_click"):
event_template["description"] = (
Expand Down