Skip to content

Conversation

@badboy
Copy link
Member

@badboy badboy commented Aug 11, 2025

Fixes #2310

Checking the public data this is based on this is (part of) what's currently in there:

[
  {
    "app": "accounts_frontend",
    "count": "1"
  },
  {
    "app": "accounts_frontend",
    "event_name": "glean.element_click.email_first_submit1DasO6R8')) OR 887=(SELECT 887 FROM PG_SLEEP(15))--",
    "count": "1"
  },

The first entry doesn't have any event_name (and others have some SQL injection tries there).
I don't actually know where we generate that file. We can probably fix it in the generation to not even generate that first entry, but regardless I think this dictionary ETL should be resistant against slightly wrong input data.

@badboy badboy requested a review from edugfilho August 11, 2025 09:48
Copy link
Contributor

@edugfilho edugfilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@badboy badboy merged commit aa0ff10 into main Aug 11, 2025
7 checks passed
@badboy badboy deleted the fix-auto-events-exception branch August 11, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment fails due to a missing event_name

3 participants