Skip to content

fix(settings): Update delete passkey modal body text #20749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vpomerleau wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fix(settings): Update delete passkey modal body text #20749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fxa-settings/src/components/Settings/SubRow/en.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ passkey-sub-row-last-used-date = Last used: { $lastUsedDate }

passkey-sub-row-delete-title = Delete passkey
passkey-delete-modal-heading = Delete your passkey?
passkey-delete-modal-content = This passkey will be removed from your account. You’ll need to sign in using a different way.
passkey-delete-modal-content-v2 = This passkey will be removed from your account. You’ll need to sign in using a different method (password, another passkey, or linked account).
passkey-delete-modal-cancel-button = Cancel
passkey-delete-modal-confirm-button = Delete passkey
passkey-delete-success = Passkey deleted
Expand Down
2 changes: 1 addition & 1 deletion packages/fxa-settings/src/components/Settings/SubRow/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ describe('PasskeySubRow', () => {
expect(await screen.findByText('Delete your passkey?')).toBeInTheDocument();
expect(
screen.getByText(
'This passkey will be removed from your account. You’ll need to sign in using a different way.'
'This passkey will be removed from your account. You’ll need to sign in using a different method (password, another passkey, or linked account).'
)
).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'Cancel' })).toBeInTheDocument();
Expand Down
5 changes: 3 additions & 2 deletions packages/fxa-settings/src/components/Settings/SubRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,10 +435,11 @@ const PasskeyDeleteModal = ({
Delete your passkey?
</h2>
</FtlMsg>
<FtlMsg id="passkey-delete-modal-content">
<FtlMsg id="passkey-delete-modal-content-v2">
<p className="mb-10 mx-4">
Comment thread
vpomerleau marked this conversation as resolved.
This passkey will be removed from your account. You’ll need to sign in
using a different way.
using a different method (password, another passkey, or linked
account).
</p>
</FtlMsg>
<div className="flex justify-center mx-2 mt-6">
Expand Down
Loading