Skip to content

fix(settings): Update delete passkey modal body text#20749

Open
vpomerleau wants to merge 1 commit into
mainfrom
FXA-13969
Open

fix(settings): Update delete passkey modal body text#20749
vpomerleau wants to merge 1 commit into
mainfrom
FXA-13969

Conversation

@vpomerleau

Copy link
Copy Markdown
Contributor

Because

  • Passkey modal body text did not match latest design

This pull request

  • Update the body text and ftl string

Issue that this pull request solves

Closes: FXA-13969

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • [ \x] If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@vpomerleau vpomerleau requested review from a team as code owners June 16, 2026 23:28
Copilot AI review requested due to automatic review settings June 16, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the passkey deletion confirmation modal copy in FxA Settings to align with the latest design language, including corresponding Fluent (FTL) strings and a test expectation update.

Changes:

  • Updated the delete-passkey modal body text in PasskeyDeleteModal.
  • Renamed/updated the Fluent string id and its English value.
  • Updated the unit test to assert the new modal body copy.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/fxa-settings/src/components/Settings/SubRow/index.tsx Updates the delete passkey modal’s localized body text (and references the new FTL id).
packages/fxa-settings/src/components/Settings/SubRow/index.test.tsx Updates assertions to match the new modal body copy.
packages/fxa-settings/src/components/Settings/SubRow/en.ftl Updates the English Fluent string for the modal body (new -v2 id).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/fxa-settings/src/components/Settings/SubRow/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants