fix(settings): Update delete passkey modal body text#20749
Open
vpomerleau wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the passkey deletion confirmation modal copy in FxA Settings to align with the latest design language, including corresponding Fluent (FTL) strings and a test expectation update.
Changes:
- Updated the delete-passkey modal body text in
PasskeyDeleteModal. - Renamed/updated the Fluent string id and its English value.
- Updated the unit test to assert the new modal body copy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/fxa-settings/src/components/Settings/SubRow/index.tsx | Updates the delete passkey modal’s localized body text (and references the new FTL id). |
| packages/fxa-settings/src/components/Settings/SubRow/index.test.tsx | Updates assertions to match the new modal body copy. |
| packages/fxa-settings/src/components/Settings/SubRow/en.ftl | Updates the English Fluent string for the modal body (new -v2 id). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toufali
approved these changes
Jun 17, 2026
bcolsson
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13969
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.