Skip to content

Minor fixes for ContentActionApproveInitialDecision.txt #25062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denyshon wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −5
Open

Minor fixes for ContentActionApproveInitialDecision.txt #25062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/olympia/abuse/templates/abuse/emails/ContentActionApproveInitialDecision.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
Hello,

{% if is_listing_rejected %}
Your {{ type }} has been approved for distribution, but the listing on Mozilla Add-ons remains unavailable until you address the violations and request a further review. You can edit it at {{ target_url }}.
Your {{ type|lower }} has been approved for distribution, but the listing on Mozilla Add-ons remains unavailable until you address the violations and request a further review. You can edit it at {{ target_url }}.
{% elif not auto_approval %}
Your {{ type }} has been approved on Mozilla Add-ons and it is now available at {{ target_url }}.
Your {{ type|lower }} has been approved on Mozilla Add-ons and it is now available at {{ target_url }}.
{% else %}
Your {{ type }} has been automatically screened and tentatively approved. It is now available at {{ target_url }}.
Your {{ type|lower }} has been automatically screened and tentatively approved. It is now available at {{ target_url }}.

Your add-on can be subject to human review at any time. Reviewers may determine that it requires changes or should be removed. If that occurs, you will receive a separate notification with details and next steps.
{% endif %}
{% if version_list %}Approved versions: {{ version_list }}
{% endif %}
{% if manual_reasoning_text %}Comments: {{ manual_reasoning_text }}.{% endif %}
{% if manual_reasoning_text %}Comments: {{ manual_reasoning_text }}{% endif %}

{% if has_attachment %}
An attachment was provided. {% if dev_url %}To respond or view the file, visit {{ dev_url }}.{% endif %}

{% endif %}
Thank you.

@eviljeff eviljeff Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative - possibly better - place to fix this is where we're saying "Thank you!" as a comment (I've not looked for it)

@denyshon denyshon Jun 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've considered that. However, in addition to "Thank you!" in the autoapproval comment, our default manual review comment is also "Thank you for your contribution." (here). So I thought it was better to remove "Thank you." here, given that it is supposed to be supplied with manual_reasoning_text


More information about Mozilla's add-on policies can be found at {{ policy_document_url }}.

Expand Down
Loading