Minor fixes for ContentActionApproveInitialDecision.txt#25062
Open
denyshon wants to merge 1 commit into
Open
Conversation
eviljeff
requested review from
a team and
nothingrandom
and removed request for
a team
eviljeff
reviewed
Jun 22, 2026
| An attachment was provided. {% if dev_url %}To respond or view the file, visit {{ dev_url }}.{% endif %} | ||
|
|
||
| {% endif %} | ||
| Thank you. |
Member
There was a problem hiding this comment.
An alternative - possibly better - place to fix this is where we're saying "Thank you!" as a comment (I've not looked for it)
Author
There was a problem hiding this comment.
I've considered that. However, in addition to "Thank you!" in the autoapproval comment, our default manual review comment is also "Thank you for your contribution." (here). So I thought it was better to remove "Thank you." here, given that it is supposed to be supplied with manual_reasoning_text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16252