fix: remove deprecated ament target dependencies#3684
Draft
wep21 wants to merge 1 commit intomoveit:mainfrom
Draft
fix: remove deprecated ament target dependencies#3684wep21 wants to merge 1 commit intomoveit:mainfrom
wep21 wants to merge 1 commit intomoveit:mainfrom
Conversation
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
wep21
force-pushed
the
remove-ament-target-dependencies
branch
from
e9694a6 to
26abb59
Compare
wep21
force-pushed
the
remove-ament-target-dependencies
branch
from
26abb59 to
b85afe4
Compare
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
- Coverage 46.24% 0.00% -46.23%
==========================================
Files 726 51 -675
Lines 59483 5938 -53545
Branches 7624 1057 -6567
==========================================
- Hits 27504 0 -27504
+ Misses 31813 5938 -25875
+ Partials 166 0 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I've started looking into this |
wep21
force-pushed
the
remove-ament-target-dependencies
branch
from
b85afe4 to
26abb59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made, including a reference to the related issue if applicable
ament/ament_cmake#614
ament_target_dependenciesis removed.Checklist