fix(filesystem): improve edit_file error with nearest-match diagnostics#3738
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
…iagnostics When edit_file fails to find a match, the error now shows the closest near-match location with line numbers, matching percentage, and a line-by-line diff highlighting which lines diverge. This helps agents and users quickly identify whitespace or content mismatches. Fixes modelcontextprotocol#2034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
edit_filefails to find a match (neither exact nor whitespace-flexible), the error message currently just dumps theoldTextwith no context about what the file actually contains. This makes it hard for both agents and humans to diagnose why the match failed.This PR improves the error to include:
Example error after this change:
No changes to the actual matching/replacement logic -- this is purely diagnostic improvement.
Fixes #2034
Test plan