Skip to content

Fix cross-platform path normalization for model loading (#541) #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheChyeahhh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix cross-platform path normalization for model loading (#541) #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions supervised/model_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,9 @@ def load(results_path, model_subpath, lazy_load=True):
for learner_desc, learner_subpath in zip(
json_desc.get("learners"), json_desc.get("saved")
):
# Normalize path separators for cross-platform compatibility
# (models trained on Windows may have backslashes in paths)
learner_subpath = learner_subpath.replace("\\", "/")
learner_path = os.path.join(results_path, learner_subpath)
l = AlgorithmFactory.load(learner_desc, learner_path, lazy_load)
mf.learners += [l]
Expand Down