Fix cross-platform path normalization for model loading (#541)#821
Open
TheChyeahhh wants to merge 1 commit into
Open
Fix cross-platform path normalization for model loading (#541)#821TheChyeahhh wants to merge 1 commit into
TheChyeahhh wants to merge 1 commit into
Conversation
When a model is trained on Windows, os.path.join stores paths with backslashes. Loading the model on Linux fails because os.path.join doesn't handle the mixed separators correctly. Fix: normalize backslashes to forward slashes before joining paths, enabling models trained on Windows to be loaded on Linux and vice versa. Closes mljar#541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a model is trained on Windows,
os.path.joinstores paths with backslashes (e.g.,model_1/100_LightGBM\\learner_fold_0.lightgbm). Loading the model on Linux fails becauseos.path.joindoesn't handle the mixed separators correctly.Fix
Normalize backslashes to forward slashes in
learner_subpathbefore joining withresults_path, enabling models trained on Windows to be loaded on Linux (and vice versa).Related Issue
Closes #541