Skip to content

✨feat: display ELR using LayRate instead min(Lay,Ship) #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Apr 2, 2026
+1 −1
Merged

✨feat: display ELR using LayRate instead min(Lay,Ship) #2309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/boost/boost_draw.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ func DrawBoostList(s *discordgo.Session, contract *Contract) []discordgo.Message
// Additions for contract state value display
sortRate := ""
if contract.State == ContractStateSignup && contract.BoostOrder == ContractOrderELR {
sortRate = fmt.Sprintf(" **ELR:%2.3f** ", min(b.ArtifactSet.LayRate, b.ArtifactSet.ShipRate))
sortRate = fmt.Sprintf(" **ELR:%2.3f** ", b.ArtifactSet.LayRate)
}
Comment on lines 363 to 366
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update changes ELR display to use LayRate here, but other ELR display paths in the same function still use min(LayRate, ShipRate) (e.g., when rendering the lateList / main orderSubset). That will result in inconsistent ELR values depending on which slice of the list a booster appears in and doesn't fully match the PR intent. Please update the other ELR formatting occurrences in DrawBoostList to use LayRate as well (or centralize the ELR display calculation in a helper) so the UI is consistent.

Copilot uses AI. Check for mistakes.
if contract.State == ContractStateSignup && contract.BoostOrder == ContractOrderTokenAsk {
sortRate = fmt.Sprintf(" **Ask:%d** ", b.TokensWanted)
Expand Down
Loading