✨feat: display ELR using LayRate instead min(Lay,Ship)#2309
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the boost list sign-up display to show ELR based on the player’s laying rate (LayRate) rather than a derived value, aligning the UI with the intended ELR interpretation used elsewhere in boost ordering.
Changes:
- Changed the ELR label formatting in
DrawBoostListto useb.ArtifactSet.LayRateinstead ofmin(LayRate, ShipRate)for one rendering path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sortRate := "" | ||
| if contract.State == ContractStateSignup && contract.BoostOrder == ContractOrderELR { | ||
| sortRate = fmt.Sprintf(" **ELR:%2.3f** ", min(b.ArtifactSet.LayRate, b.ArtifactSet.ShipRate)) | ||
| sortRate = fmt.Sprintf(" **ELR:%2.3f** ", b.ArtifactSet.LayRate) | ||
| } |
There was a problem hiding this comment.
This update changes ELR display to use LayRate here, but other ELR display paths in the same function still use min(LayRate, ShipRate) (e.g., when rendering the lateList / main orderSubset). That will result in inconsistent ELR values depending on which slice of the list a booster appears in and doesn't fully match the PR intent. Please update the other ELR formatting occurrences in DrawBoostList to use LayRate as well (or centralize the ELR display calculation in a helper) so the UI is consistent.
No description provided.